Open
Conversation
Signed-off-by: Chih-Chen Kao <ChihChen.Kao@amd.com>
Signed-off-by: Chih-Chen Kao <ChihChen.Kao@amd.com>
Signed-off-by: Chih-Chen Kao <ChihChen.Kao@amd.com>
Signed-off-by: Chih-Chen Kao <ChihChen.Kao@amd.com>
…rt-OS-fixedalloc # Conflicts: # ParallelPrimitives/RadixSort.cpp # ParallelPrimitives/RadixSort.h # ParallelPrimitives/RadixSort.inl # ParallelPrimitives/RadixSortKernels.h
…rt-OS-fixedalloc # Conflicts: # ParallelPrimitives/RadixSort.cpp # ParallelPrimitives/RadixSort.h # ParallelPrimitives/RadixSortKernels.h
…rt-OS-fixedalloc # Conflicts: # ParallelPrimitives/RadixSort.cpp
KaoCC
reviewed
Feb 27, 2024
| static_assert( DEFAULT_SCAN_BLOCK_SIZE % DEFAULT_WARP_SIZE == 0 ); | ||
| constexpr int WARP_SIZE = 32; | ||
|
|
||
| constexpr int RADIX_SORT_BLOCK_SIZE = 4096; |
There was a problem hiding this comment.
Does this mean that in this version, the block size and the parameters below are all fixed again ?
Author
There was a problem hiding this comment.
Yes. but even with fixed size, the temporal allocation is fixed.
KaoCC
reviewed
Mar 1, 2024
| void sort( const KeyValueSoA& src, const KeyValueSoA& dst, uint32_t n, int startBit, int endBit, oroStream stream = 0 ) noexcept; | ||
|
|
||
| void sort( const u32* src, const u32* dst, int n, int startBit, int endBit, oroStream stream = 0 ) noexcept; | ||
| void sort( u32* src, u32* dst, uint32_t n, int startBit, int endBit, oroStream stream = 0 ) noexcept; |
There was a problem hiding this comment.
src should remain constant. It is a pointer to a const u32 array.
| // Floor | ||
| number_of_blocks = ( number_of_blocks / base ) * base; | ||
| } | ||
| // TODO: bit code support? |
There was a problem hiding this comment.
not sure what to do about this ... should we disable bitcode for now ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is faster and more robust for conflicts keys than this #71
key about 12.10GKeys/s-> 14.34GKeys/s
key value about 7.65GKeys/s -> 7.91GKeys/s
( including copy, with many conflicts due to the current key preparations )