Use VkFFT from OpenMM 8.1 #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenMM 8.1 includes VkFFT.h version 1.2.33, which has some HIP speed improvements.
Contributor
|
Hi, I assume that these are optimizations we first implemented here: https://github.com/amd/openmm-hip/commits/master/platforms/hip/include/vkFFT.h (d97c6bd) Does 1.2.33 include all of them? |
Author
|
From what I can tell, it includes the first 2 PRs. DTolm/VkFFT#105 was implemented in 1.3.0 so it would be missing. I'm testing on RDNA2 and that optimization is not applied so I didn't notice the lack of it. I guess this will have to wait until OpenMM upgrades to VkFFT 1.3.0+. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenMM 8.1 includes VkFFT.h version 1.2.33, which has some HIP speed improvements.