Skip to content

Support count response #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javierg merged 2 commits into from
Dec 23, 2025
+16 −0
Merged

Support count response #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd3326d
Support count response
javierg Dec 23, 2025
6a08c68
remove extra space
javierg Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/cyphi/client/response.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ defmodule Cyphi.Client.Response do
parse(module, map, type)
end

defp parse(_module, %{"count" => count}, _type) do
count
end

defp parse(module, map, type) do
attrs =
module.__fields__(type)
Expand Down
12 changes: 12 additions & 0 deletions test/cyphi/client_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,18 @@ defmodule Cyphi.ClientTest do
end)
end

test "count list request returns amount" do
opts = %{
method: :get,
url: "/badges",
response: [{200, [{Cyphi.Badge, :t}]}]
}

with_response(%{status: 200, body: %{"count" => 10}}, fn ->
assert {:ok, 10} == Client.request(opts)
end)
end

test "single item request returns decoded response (GET)" do
opts = %{
method: :get,
Expand Down