fix: boti smearing #1973
Open
fix: boti smearing #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isaiah Crace <isaiahcrace@gmail.com>
github-actions
bot
added
S: Needs Review
Member
Author
|
technically, this will improve performance since we're now clearing the buffer |
… the previous viewport Signed-off-by: Isaiah Crace <isaiahcrace@gmail.com>
github-actions
bot
added
size/M
Signed-off-by: Isaiah Crace <isaiahcrace@gmail.com>
Signed-off-by: Isaiah Crace <isaiahcrace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Correctly clear the framebuffer before copying the data to get rid of the stupid smearing issues.
Why / Balance
This fixes a long-standing technical issue for many users, especially on AMD GPU's.
Technical details
After setting up the framebuffer for copying, we begin writing to the offscreen boti framebuffer, clearing it, and continuing on to the copying step where we give it the rendered data.
Media
Requirements
Breaking changes
Changelog
🆑