Skip to content

refactor: everything is now translatable prolly #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
duzos wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: everything is now translatable prolly #1955

duzos wants to merge 3 commits into from

Conversation

@duzos
Copy link
Member

@duzos duzos commented Dec 14, 2025

refactor nameable to properly implement translation keys instead of a predefined "name" value

@duzos duzos requested a review from a team as a code owner December 14, 2025 19:07
@github-actions github-actions bot added the size/M Denotes a PR that changes 100-999 lines. label Dec 14, 2025
@duzos
Copy link
Member Author

duzos commented Dec 14, 2025

needs testing

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. A: Datagen Area: Datagen implementation & API. A: Tardis Components Area: Tardis components & manager. A: Admin Tooling Area: Admin tooling and moderation. labels Dec 14, 2025
@github-actions
Copy link

github-actions bot commented Dec 14, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. label Dec 14, 2025
drtheodor
drtheodor requested changes Dec 26, 2025
View reviewed changes
Copy link
Member

@drtheodor drtheodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont forget to triage

src/main/java/dev/amble/ait/api/Nameable.java
// TODO: make it so if the object is Nameable AND Identifiable, use Identifier#toTranslationKey
public interface Nameable {
String name();
default String toTranslationKey() {
Copy link
Member

@drtheodor drtheodor Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overhead.

Copy link
Member Author

@duzos duzos Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdym overhead

duzos added 2 commits January 15, 2026 05:29
@duzos
Merge branch 'main' into refactor/nameable
f13b044 
# Conflicts:
#	src/main/java/dev/amble/ait/datagen/AITModDataGenerator.java
@duzos
resolve issues
4bc285d
@duzos duzos requested a review from drtheodor January 15, 2026 05:31
@github-actions github-actions bot added S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. labels Jan 15, 2026
@github-actions
Copy link

github-actions bot commented Jan 20, 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drtheodor drtheodor Awaiting requested review from drtheodor

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

A: Admin Tooling Area: Admin tooling and moderation. A: Datagen Area: Datagen implementation & API. A: Tardis Components Area: Tardis components & manager. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. S: Needs Review Status: Requires additional reviews before being fully accepted. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@duzos @drtheodor