Skip to content

chore: giant cleanup #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
drtheodor wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: giant cleanup #1940

drtheodor wants to merge 2 commits into from

Conversation

@drtheodor
Copy link
Member

@drtheodor drtheodor commented Oct 25, 2025

About the PR

This PR contains a helluva lot of cleanup & formatting fixes, as well as a removal of deprecated stuff.

Requirements

Breaking changes

  • DoorModel now inherits BlockEntityModel from amblekit.
  • Tardis#interiorChangingHandler was removed (use #interiorChanging instead).
  • Deprecated HorizontalDirectedBlock in favor of HorizontalBlockBehavior (Block Behavior API) or HorizontalFacingBlock.
  • Removed travel sounds stuff that has been deprecated for ages.

Changelog

:nocl:

@drtheodor
chore: basic cleanup & fmt
6e99396 
chore: remove deprecated TravelSoundRegistry and #interiorChangingHandler
@drtheodor
finishing touches
cf59e21
@drtheodor drtheodor requested a review from a team as a code owner October 25, 2025 15:45
@drtheodor drtheodor added the T: Cleanup Type: Code clean-up, without being a full refactor or feature. label Oct 25, 2025
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. A: Datagen Area: Datagen implementation & API. A: Tardis Components Area: Tardis components & manager. A: Engine Area: Tardis engine. A: Admin Tooling Area: Admin tooling and moderation. A: Console Area: Tardis console. size/M Denotes a PR that changes 100-999 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. labels Oct 25, 2025
@GSMPBot GSMPBot requested a review from duzos October 25, 2025 15:45
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted. label Oct 25, 2025
@github-actions
Copy link

github-actions bot commented Oct 27, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. label Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duzos duzos Awaiting requested review from duzos

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

A: Admin Tooling Area: Admin tooling and moderation. A: Console Area: Tardis console. A: Datagen Area: Datagen implementation & API. A: Engine Area: Tardis engine. A: Tardis Components Area: Tardis components & manager. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. S: Needs Review Status: Requires additional reviews before being fully accepted. size/M Denotes a PR that changes 100-999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drtheodor