Skip to content

feat: Real World Flight! #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Loqor wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: Real World Flight! #1934

Loqor wants to merge 5 commits into from

Conversation

@Loqor
Copy link
Member

@Loqor Loqor commented Oct 22, 2025 •
edited by drtheodor
Loading

About the PR

RWF

Why / Balance

RWF

Technical details

I don't need to. It's RWF.

Media

Requirements

Breaking changes

Changelog

🆑

  • RWF

@Loqor
feat: Real World Flight!
a5cb7cc 
fix: rwf no longer dupes exterior
fix: falling (kind of)
DONT USE WITH IP
@Loqor Loqor requested a review from a team as a code owner October 22, 2025 15:56
@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. A: Datagen Area: Datagen implementation & API. S: Needs Review Status: Requires additional reviews before being fully accepted. A: Tardis Components Area: Tardis components & manager. A: Console Area: Tardis console. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Oct 22, 2025
@GSMPBot GSMPBot requested review from drtheodor and duzos October 22, 2025 15:56
@Loqor
fix: flight sound
41b75dc 
fix: exterior block spam
@Loqor Loqor added S: Help Wanted Status: Requesting additional help for this to be completed. S: Draft Status: This is a draft and might need to be retriaged upon opening. S: DO NOT MERGE Status: Open item that should NOT be merged. DNM. Allows test to run unlike draft. labels Oct 22, 2025
@drtheodor drtheodor changed the title feat: Real World Flight! fix: rwf no longer dupes exterior fix: falling (kind of) DONT USE WITH IP feat: Real World Flight! Oct 22, 2025
@drtheodor
Copy link
Member

drtheodor commented Oct 22, 2025

So, a small rundown of stuff that needs to be fixed before this PR can be reviewed:

  • fix tardis networking (still an issue)
  • fix tardis falling (or disable falling like how it is in main)
  • remove the absolutely atrocious play/stop sound packets (or at least move them away from AITMod and AITModClient, those classes are already bloated with all kind of shit)
  • possibly more (havent checked the code yet)

Loqor added 3 commits October 22, 2025 13:34
@Loqor
fix: exterior flight sound is dependent on distance
0a51b30 
fix: velocity on client maybe? i saw other renderers using it so it makes sense..
spotless apply
@Loqor
fix: velocity
e1e7e38 
fix: audio?
fix: ur mother's relationship with your father (JUST KIDDING HAHA)
@Loqor
fix: velocity HOPEFULLY
fe7557f
@github-actions
Copy link

github-actions bot commented Oct 25, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. label Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drtheodor drtheodor Awaiting requested review from drtheodor

@duzos duzos Awaiting requested review from duzos

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

A: Console Area: Tardis console. A: Datagen Area: Datagen implementation & API. A: Tardis Components Area: Tardis components & manager. S: DO NOT MERGE Status: Open item that should NOT be merged. DNM. Allows test to run unlike draft. S: Draft Status: This is a draft and might need to be retriaged upon opening. S: Help Wanted Status: Requesting additional help for this to be completed. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. S: Needs Review Status: Requires additional reviews before being fully accepted. size/M Denotes a PR that changes 100-999 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Loqor @drtheodor