Feature/config #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amespaced structure - Add config package with JSON file storage in ~/.pho/config.json - Support namespaced config keys (mongo.*, postgres.*, app.*, etc) - Implement config CLI commands: get, set, list - Add environment variable override support for all config settings - Integrate config defaults with CLI flags and environment sources - Design future-proof architecture for PostgreSQL support - Add comprehensive test coverage for config functionality - Maintain backward compatibility with existing MongoDB workflow Features: • Configuration file: ~/.pho/config.json with proper permissions • CLI commands: pho config get/set/list with validation and aliases • Environment override: All settings can be overridden via PHO_* env vars • Database agnostic: Separate mongo.* and postgres.* namespaces • Full integration: CLI flags use config defaults with env var precedence • Type safety: Proper validation for timeouts, limits, boolean values • Extensible: Easy to add new config sections and settings
- Replace JSON serialization with TOML using github.com/BurntSushi/toml - Update all struct tags from json to toml format - Change configuration file from config.json to config.toml - Move config directory from ~/.pho to ~/.config/pho following XDG spec - Update config parsing and marshaling logic accordingly - Update tests to use TOML format and new file paths - All functionality remains the same, only storage format changed
- Remove PostgreSQL configuration struct and related code (not supported yet) - Remove PostgreSQL environment variable handling - Remove PostgreSQL config keys from Set/Get methods - Update tests to remove PostgreSQL references - Add support for pho config list [section] command - Update configuration path references from ~/.pho to ~/.config/pho - Add section shortcuts: mongo, database, query, app, output, directories - Improve error handling for unknown sections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.