Refactor: reorganize how shell scripts are structured #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix all shellcheck warnings (SC2155, SC2129, SC2015, SC1091, SC2034) - Separate variable declaration and assignment to avoid masking return values - Group multiple file redirects using brace syntax for better performance - Replace ambiguous A && B || C patterns with explicit if-then statements - Add shellcheck disable directives for unavoidable warnings - Export or properly handle unused variables - Reorganize scripts directory structure for better separation of concerns - Move colors.sh and common.sh to scripts/src/ alongside template files - Update all path references in build.sh and source templates - Refactor _get_script_dir function to handle new common.sh location - Standardize color variable usage by removing duplicate RESET/NC variables - Remove RESET variable and use NC consistently across all scripts - Update all template files and logging functions - Add shellcheck task to Makefile as 'make sc' for continuous quality checking - Includes proper error handling to not fail build on warnings - Covers all shell script types (.sh, .bash, .zsh) - Improve zsh hook file compatibility - Add proper shebang to git-undo-hook.zsh - Disable shellcheck for zsh-specific syntax not supported by shellcheck
amberpixels
changed the title
amberpixels
pushed a commit
that referenced
this pull request
Jun 13, 2025
* refactor: scripts/src files to be separated * refactor: improve shell script quality and organization - Fix all shellcheck warnings (SC2155, SC2129, SC2015, SC1091, SC2034) - Separate variable declaration and assignment to avoid masking return values - Group multiple file redirects using brace syntax for better performance - Replace ambiguous A && B || C patterns with explicit if-then statements - Add shellcheck disable directives for unavoidable warnings - Export or properly handle unused variables - Reorganize scripts directory structure for better separation of concerns - Move colors.sh and common.sh to scripts/src/ alongside template files - Update all path references in build.sh and source templates - Refactor _get_script_dir function to handle new common.sh location - Standardize color variable usage by removing duplicate RESET/NC variables - Remove RESET variable and use NC consistently across all scripts - Update all template files and logging functions - Add shellcheck task to Makefile as 'make sc' for continuous quality checking - Includes proper error handling to not fail build on warnings - Covers all shell script types (.sh, .bash, .zsh) - Improve zsh hook file compatibility - Add proper shebang to git-undo-hook.zsh - Disable shellcheck for zsh-specific syntax not supported by shellcheck * cleanup
amberpixels
added a commit
that referenced
this pull request
Jun 13, 2025
* refactor: scripts/src files to be separated * refactor: improve shell script quality and organization - Fix all shellcheck warnings (SC2155, SC2129, SC2015, SC1091, SC2034) - Separate variable declaration and assignment to avoid masking return values - Group multiple file redirects using brace syntax for better performance - Replace ambiguous A && B || C patterns with explicit if-then statements - Add shellcheck disable directives for unavoidable warnings - Export or properly handle unused variables - Reorganize scripts directory structure for better separation of concerns - Move colors.sh and common.sh to scripts/src/ alongside template files - Update all path references in build.sh and source templates - Refactor _get_script_dir function to handle new common.sh location - Standardize color variable usage by removing duplicate RESET/NC variables - Remove RESET variable and use NC consistently across all scripts - Update all template files and logging functions - Add shellcheck task to Makefile as 'make sc' for continuous quality checking - Includes proper error handling to not fail build on warnings - Covers all shell script types (.sh, .bash, .zsh) - Improve zsh hook file compatibility - Add proper shebang to git-undo-hook.zsh - Disable shellcheck for zsh-specific syntax not supported by shellcheck * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.