Add support for blacklisting modules #2
Conversation
Signed-off-by: Vallish Vaidyeshwara <vallish@amazon.com> Reviewed-by: Balbir Singh <sblbir@amazon.com> Reviewed-by: Frederick Lefebvre <fredlef@amazon.com> Reviewed-by: Frank van der Linden <fllinden@amazon.com>
Non-root users executing autotune fail trying to grab the service lock. However this code flow is not user friendly. Root check needs to be more gracious and user friendly. Signed-off-by: Vallish Vaidyeshwara <vallish@amazon.com> Reviewed-by: Balbir Singh <sblbir@amzn.com>
Signed-off-by: Vallish Vaidyeshwara <vallish@amazon.com> Reviewed-by: Balbir Singh <sblbir@amzn.com>
…easier to add new sections Signed-off-by: Balbir Singh <sblbir@amzn.com>
Add support for blacklisting un-needed modules. This support today does not take instance type into account, but in the future we would want to consider Signed-off-by: Balbir Singh <sblbir@amzn.com>
This patch adds support for generation of actual changes to /etc/modprobe.d/blacklist.conf. The code checks to see if the blacklist <module> already exists in any of the files in /etc/modprobe.d and if so, skips it. Support is also added for rollback of the config via autotune rollback Signed-off-by: Balbir Singh <sblbir@amzn.com>
Signed-off-by: Balbir Singh <sblbir@amzn.com>
Signed-off-by: Balbir Singh <sblbir@amzn.com>
vallishgv
left a comment
vallishgv
left a comment
There was a problem hiding this comment.
This patch series can leave blacklisted modules configured in the case of "autotune apply" and the system crashes after autotune configures the system. Since these changes are always required for EC2 instances, it would be better if we move the logic of blacklisting modules to %post and have it run as part of autotune package installation.
|
Once we move the logic into %post, we would not need to worry about reverting blacklisting of modules. Blacklisting of modules is one time effort. |
|
autotune's original scope was optimizing system performance - how does blacklisting modules fall in to that scope? It it does, then that's fine, but if it doesn't, the scope of autotune is being widened to system configuration - not just system optimization. I'm weary of feature creep. |
4 participants
*By default, this will create state in the form of /etc/modprobe.d/blacklist.conf, which should all work as expected as long as the service is running and stopped during startup and reboot. Corner cases such as apply/stop service and reboot, will leave the state file behind
Review suggestions -- areas that need closer look
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.