Faster access to the list of dataflows#228
Open
viguice wants to merge 9 commits intoamattioc:masterfrom
Open
Conversation
Workaround when proxy returns HTTP_PROXY_AUTH code
… after switching to another provider.
… if it is really compressed (Eurostat doesn't return Content-Encoding header tag).
Merge pull request amattioc#227 from viguice/viguice
amattioc
previously approved these changes
Sep 6, 2023
Owner
|
Hi @viguice thanks a lot for the time you spent on this. The compression is now being managed in the provider properties, using the file that has been introduced recently. Every provider will need to show if it supports compression. Regarding the allstubs option, it has to be managed in a more granular way: in the helper teh dsds are needed because you could want to check what flows are related to the same structure. In the getflows calls outside the helper it can be useful to improve response time. I'll try to add this behaviour in next releases. I also already introduced the many small code fixes that you had put in the code, thanks for them as well! Attilio |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My first test was showing that the app was a bit too slow to my taste for loading all dataflows from a provider.
To improve the performance, I have
The next steps would be: