Sort hashes in templates #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ppet run (and so, ssh is not restarted without need)
Add ssh::server::host_key
Conflicts: manifests/client/install.pp manifests/server/install.pp
Really make $ensure variable
Allow turning off storeconfigs/hostkey managment
I see this warning when I render this template: modules/ssh/templates/sshd_config.erb:3: warning: string literal in condition Im not sure if this effects all versions of ruby or what. I think that this was your intension. Let me know if this isn't want you wanted here. On: ubuntu ruby 1.9.3p0 puppet 3.4.3
Make logic explicit in template.
the other options should be ordered too, in order to not changing file in every execution
Fix to correctly order: Although Match option must be the last one, the other options should be ordered too, in order to not changing file in every execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have modified ssh templates in order to sort hashes, so files are not modified in every puppet run