Skip to content

Conversation

@frogarian
Copy link
Contributor

note: this slightly changes the layout of the bottom row

  • . left
  • 0 center
  • Enter spaning the two right columns

IMHO it looks nicer that all keys are properly aligned with the 0 as usual in the center.

note: this slightly changes the layout of the bottom row
@gemini-code-assist
Copy link

Summary of Changes

Hello @frogarian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the user interface of the digit input panel by refactoring its QML layout. By transitioning from nested ColumnLayout and RowLayout components to a more streamlined GridLayout, the change achieves better key alignment and a more intuitive arrangement, especially for the bottom row keys. The primary goal is to provide a cleaner and more standard calculator-like layout for improved usability.

Highlights

  • Layout Refactoring: The DigitsLayout.qml component has been refactored to use a GridLayout instead of a combination of ColumnLayout and RowLayouts, simplifying the layout structure.
  • Improved Key Alignment: The change aims to improve the visual alignment of keys, particularly in the bottom row, by centering the 0 key and aligning other keys more consistently.
  • Bottom Row Layout Adjustment: The bottom row of the digit panel now features the decimal point key on the left, the 0 key in the center, and the Enter key spanning two columns on the right.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors DigitsLayout.qml to use a GridLayout instead of nested RowLayouts. This is an excellent change that significantly improves the code's readability and maintainability. The new layout for the bottom row is also implemented correctly. I have one minor suggestion regarding a potentially confusing and unused property that could be cleaned up.

Copy link
Contributor

@AndreaRicchi AndreaRicchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the improvement

@AndreaRicchi AndreaRicchi merged commit 082878a into amarula:main Nov 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants