Skip to content

fix: fetch correct price list when creating SI (backport #6) #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barredterra merged 1 commit into from
Jan 30, 2026
Merged

fix: fetch correct price list when creating SI (backport #6) #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions simple_subscription/simple_subscription/doctype/simple_subscription/simple_subscription.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@
from enum import Enum

import frappe
from erpnext.accounts.doctype.sales_invoice.sales_invoice import SalesInvoice
from erpnext.accounts.party import get_party_details
from frappe import _
from frappe.model.document import Document

from erpnext.accounts.doctype.sales_invoice.sales_invoice import SalesInvoice
from frappe.utils import today


class Frequency(Enum):
Expand Down Expand Up @@ -47,6 +48,7 @@ def create_invoice(self, from_date: date, to_date: date) -> SalesInvoice:
invoice = frappe.new_doc("Sales Invoice")
invoice.company = self.company
invoice.customer = self.customer
invoice.selling_price_list = self.get_price_list()
for row in self.items:
invoice.append(
"items",
Expand All @@ -62,6 +64,28 @@ def create_invoice(self, from_date: date, to_date: date) -> SalesInvoice:
invoice.set_missing_values()
return invoice.insert()

def get_price_list(self) -> str | None:
currency = self.currency or frappe.get_cached_value("Company", self.company, "default_currency")

party_details = get_party_details(
party=self.customer,
account=None,
party_type="Customer",
company=self.company,
posting_date=today(),
currency=currency,
doctype="Sales Invoice",
fetch_payment_terms_template=False,
)

price_list = (
party_details.selling_price_list
or frappe.db.get_single_value("Selling Settings", "selling_price_list")
or frappe.db.get_value("Price List", {"selling": 1, "currency": currency, "enabled": 1})
)

return price_list or None


@frappe.whitelist()
def create_current_invoice(subscription_name: str, silent=False):
Expand Down
20 changes: 1 addition & 19 deletions ...cription/simple_subscription/doctype/simple_subscription_item/simple_subscription_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import frappe
from frappe.model.document import Document
from erpnext.stock.get_item_details import get_item_details
from erpnext.accounts.party import get_party_details
from frappe.utils import today


Expand All @@ -16,24 +15,7 @@ def current_rate(self):
"Company", parent.company, "default_currency"
)

party_details = get_party_details(
party=parent.customer,
account=None,
party_type="Customer",
company=parent.company,
posting_date=today(),
currency=currency,
doctype="Sales Invoice",
fetch_payment_terms_template=False,
)

price_list = (
party_details.selling_price_list
or frappe.db.get_single_value("Selling Settings", "selling_price_list")
or frappe.db.get_value(
"Price List", {"selling": 1, "currency": currency, "enabled": 1}
)
)
price_list = parent.get_price_list()

item_details = get_item_details(
{
Expand Down
Loading