Add very basic handling of access_by_lua_block#15
Open
pugmajere wants to merge 2 commits intoaluttik:masterfrom
Open
Add very basic handling of access_by_lua_block#15pugmajere wants to merge 2 commits intoaluttik:masterfrom
pugmajere wants to merge 2 commits intoaluttik:masterfrom
Conversation
This is mostly so that directives *following* the lua block get properly mapped to the location directive. This also adds a few debugging tools for understanding the parsing process and *when* errors are happening.
Author
|
I don't feel like this fixes #1 but it does somewhat reduce the friction, I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This detects access_by_lua_block and consumes the block, rather than attempting to do anything more interesting with it.
(Other *_by_lua_block directives could be handled similarly, but aren't covered in this change.)
It should be possible to preserve the block in some fashion in the future. The main goal of this change is to fix the parsing so directives after a lua block are not treated as being inside the lua block.
The "}" was getting picked up during "args" processing and not triggering an exit from Parse().