Conversation
jorgemarpa
reviewed
Mar 24, 2026
Collaborator
jorgemarpa
left a comment
jorgemarpa
left a comment
There was a problem hiding this comment.
this looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes minor bugs identified whilst creating the TESS asteroids HLSP database. Changes include:
_make_primary_hdu(). In a few rare cases, the computed value of VMAG and HMAG was nan, meaning the code would error because a nan cannot be saved in a FITS header. This has been fixed by catching nans and setting to None._create_lc_quality()to identify these cadences.create_lc_quality_mask()if quality arrays are empty (can happen very rarely for PSF photometry if all data is flagged as bad quality).plot_lc()to only plot data if lightcurve is not empty (can happen very rarely for PSF photometry if all data is flagged as bad quality)._data_chunks()which was incorrectly returning a warning for sector 97 and 98.