Skip to content

fix: Change AnalysisRule from Warning to Lint #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riscait merged 1 commit into from
Dec 5, 2025
Merged

fix: Change AnalysisRule from Warning to Lint #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/altive_lints/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.0.0-dev.2

- **FIX**: Changed the AnalysisRule that had been registered as a Warning rule to be registered as a Lint rule.

## 2.0.0-dev.1

- Bumped minimum Dart SDK to 3.10 (required by the analyzer plugin).
Expand Down
2 changes: 1 addition & 1 deletion packages/altive_lints/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ linter:
- public_member_api_docs: false

plugins:
altive_lints: ^2.0.0-dev.1
altive_lints:
diagnostics:
# Explicitly disable one analysis rule.
avoid_consecutive_sliver_to_box_adapter: false
Expand Down
10 changes: 10 additions & 0 deletions packages/altive_lints/lib/altive_lints.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,16 @@ formatter:
plugins:
altive_lints:
path: ../../altive_lints
diagnostics:
avoid_consecutive_sliver_to_box_adapter: true
avoid_hardcoded_color: true
avoid_hardcoded_japanese: true
avoid_shrink_wrap_in_list_view: true
avoid_single_child: true
prefer_clock_now: true
prefer_dedicated_media_query_methods: true
prefer_space_between_elements: true
prefer_to_include_sliver_in_name: true

linter:
rules:
Expand Down
18 changes: 9 additions & 9 deletions packages/altive_lints/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@ class _Plugin extends Plugin {
@override
Future<void> register(PluginRegistry registry) async {
registry
..registerWarningRule(AvoidConsecutiveSliverToBoxAdapter())
..registerWarningRule(AvoidHardcodedColor())
..registerWarningRule(AvoidHardcodedJapanese())
..registerWarningRule(AvoidShrinkWrapInListView())
..registerWarningRule(AvoidSingleChild())
..registerWarningRule(PreferClockNow())
..registerWarningRule(PreferDedicatedMediaQueryMethods())
..registerWarningRule(PreferSpaceBetweenElements())
..registerWarningRule(PreferToIncludeSliverInName())
..registerLintRule(AvoidConsecutiveSliverToBoxAdapter())
..registerLintRule(AvoidHardcodedColor())
..registerLintRule(AvoidHardcodedJapanese())
..registerLintRule(AvoidShrinkWrapInListView())
..registerLintRule(AvoidSingleChild())
..registerLintRule(PreferClockNow())
..registerLintRule(PreferDedicatedMediaQueryMethods())
..registerLintRule(PreferSpaceBetweenElements())
..registerLintRule(PreferToIncludeSliverInName())
Comment on lines +29 to +37
Copy link

@gemini-code-assist gemini-code-assist bot Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, consider grouping these rule registrations. You can define a list of rules and iterate over it to register them. This makes adding or removing rules cleaner.

For example:

final lintRules = <AnalysisRule>[
  AvoidConsecutiveSliverToBoxAdapter(),
  AvoidHardcodedColor(),
  AvoidHardcodedJapanese(),
  AvoidShrinkWrapInListView(),
  AvoidSingleChild(),
  PreferClockNow(),
  PreferDedicatedMediaQueryMethods(),
  PreferSpaceBetweenElements(),
  PreferToIncludeSliverInName(),
];

for (final rule in lintRules) {
  registry.registerLintRule(rule);
}

This would replace the current chain of registerLintRule calls.

Copy link
Member Author

@riscait riscait Dec 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gemini-code-assist
How about this?

    <AnalysisRule>[
      AvoidConsecutiveSliverToBoxAdapter(),
      AvoidHardcodedColor(),
      AvoidHardcodedJapanese(),
      AvoidShrinkWrapInListView(),
      AvoidSingleChild(),
      PreferClockNow(),
      PreferDedicatedMediaQueryMethods(),
      PreferSpaceBetweenElements(),
      PreferToIncludeSliverInName(),
    ].forEach(registry.registerLintRule);

..registerAssist(AddMacroDocumentComment.new)
..registerAssist(AddMacroTemplateDocumentComment.new)
..registerAssist(WrapWithMacroTemplateDocumentComment.new)
Expand Down
2 changes: 1 addition & 1 deletion packages/altive_lints/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: altive_lints
description: >-
Provides `all_lint_rules.yaml` that activates all rules and
`altive_lints.yaml` with Altive recommended rule selection.
version: 2.0.0-dev.1
version: 2.0.0-dev.2
homepage: https://altive.dev
repository: https://github.com/altive/altive_lints
issue_tracker: https://github.com/altive/altive_lints/issues
Expand Down