fix(build): Change NSIS installer to per-user to avoid SmartScreen #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed perMachine from true to false - Per-user installers don't require admin privileges - Windows SmartScreen is more permissive without code signing certificate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Windows SmartScreen was aggressively blocking the installer because it required administrator privileges (perMachine: true) without having a code signing certificate.
Solution
Changed NSIS installer configuration from per-machine to per-user installation:
Impact
Testing
Tested on Windows with no code signing certificate - SmartScreen no longer blocks the installer.