fix: remove auto-update feature (electron-updater) #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the entire auto-update system due to Windows Smart App Control blocking unsigned executables with no bypass option available. Removed: - electron-updater dependency from package.json - UpdateManager service (electron/src/services/updater/) - Update IPC handlers (electron/src/services/ipc/update-handlers) - Update interfaces (electron/src/interfaces/update.interface) - Angular UpdateService (src/app/services/update/) - Settings updates page (src/app/pages/open-settings-updates/) - Update dialog component (src/app/components/open-update-dialog/) - Update-related translations from i18n files - Update route from app.routes.ts - Update menu item from Help menu - Update API declarations from electron.d.ts and preload.ts - build.publish config from package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Removed
Why
Windows Smart App Control blocks unsigned executables with no bypass option. Azure Trusted Signing requires an organization identity in the EU (individual developers only supported in USA/Canada). Until code signing is resolved, the auto-update feature causes more problems than it solves since users cannot run the downloaded updates.
Testing
pm run dev\ builds and runs without errors
px vitest run\ - 360 tests passed, 0 failed
Type of Change