Fix/calendar colors #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some sonar qube and refactor services altaskur#18
…oved color management
…tle surface variable
… use new color variables
…r authentication Current lts-community image uses old sonar.login parameter instead of sonar.token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a semantic color system to the application's styles, replacing direct usage of palette variables with new semantic CSS custom properties. This makes it easier to manage color themes (like light and dark modes) and improves maintainability and consistency across the UI. The changes affect several SCSS files and add new semantic color definitions to the global stylesheet.
Semantic color system introduction:
--c-positive-bg,--c-surface-muted, etc.) for both light and dark modes instyles.scss, mapping them to existing palette variables or color mixes.Refactoring component styles to use semantic colors:
open-calendar.scss,open-day-override-dialog.scss,open-time-entry-dialog.scss, andopen-work-config-dialog.scssto replace direct palette variable usage (e.g.,--p-green-50,--p-surface-100) with the new semantic color variables. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19]Other improvements:
-Dsonar.loginparameter, ensuring compatibility with older SonarQube versions.