UCM2: Intel: sof-hda-dsp: Enable Dmic0 pre-processing and SDW speaker post-processing #481

singalsu · 2024-12-03T13:38:45Z

This patch adds enable of the microphone capture pre-processing features as BootSequence inital values if the controls for them are available. If the user later switches these off, they will remain off.

The DRC is dynamic range control that boosts the capture level, and the TDFB (time-domain fixed beamformer) improves capture signa-to-noise ratio for set beam angle direction. The used 0 degrees angle is defined as angle towards notebook computer user.

ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf

ucm2/Intel/sof-hda-dsp/dsp.conf

ucm2/blobs/sof/ipc4/drc/README.md

ucm2/Intel/sof-hda-dsp/dsp.conf

singalsu · 2024-12-13T18:10:40Z

Converted to draft, this needs more testing. Also I will add a SDW speaker playback control patch.

singalsu · 2024-12-17T13:46:31Z

Note: Added as 6th commit enable of SDW microphone array pre-processing in SOF after I got a device where I was able to test it.

ucm2/Intel/sof-hda-dsp/dsp.conf

ujfalusi

@singalsu, I only have one real question, the other two are just nitpicks

ucm2/Intel/sof-hda-dsp/dsp.conf

ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf

ucm2/sof-soundwire/sof-soundwire.conf

singalsu · 2025-01-13T10:10:08Z

@perexg Can you please check this PR, thanks!

This patch moves SOF control blobs related variables set are to a new dsp.conf that is included from top level sof-hda-dsp.conf. The change allows to use the variables in InitBootSequence for the controls. E.g. customize the default blobs applied based on DMI ID of the device. There's no change to functionality in this patch. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

singalsu · 2025-01-24T17:31:15Z

No functional changes since push in December. Now fixed the spaces in two lines to tabs (found by ucm_validate).

singalsu · 2025-01-27T15:13:59Z

@perexg What's up? It looks like last merged UCM patches from Github are are from mid-December. If you have time, feedback for this PR is very much welcome even if you would not be yet able accept and merge. The motivation for these patches is to get the sound experience with Linux & SOF on a notebook to better match a Windows install on same device, e.g. playback and capture loudness.

perexg · 2025-01-27T15:36:11Z

ucm2/Intel/sof-hda-dsp/dsp.conf

+}
+
+Define {
+	PostMixerAnalogPlaybackIirBytes "not available"


Just nitpicking. I would use "N/A" here to save some space.

Yep, that's better - Fixed.

perexg · 2025-01-27T15:36:55Z

ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf

+			]
+			Macro.Dmic0.SofEqBootSetup "endpoint='Dmic0' direction='Capture' eqtype='Iir'"
+			Macro.Dmic0.SofDrcBootSetup "endpoint='Dmic0' direction='Capture'"
+			Macro.Dmic0.SofBeamformerBootSetup "endpoint=Dmic0 direction=Capture"


Nitpicking: Use 'STR' everywhere or remove '' everywhere.

I'm not sure what to do, please help me to start. Can you point me an example .conf in UCM2 to follow for quotes style. Also, is https://www.alsa-project.org/alsa-doc/alsa-lib/group__ucm__conf.html up-to-date for using 'x' and "y"?

Ah, above Capture should be 'Capture' ... I'll see if I have similar missed ''.

Fixed, I was blind.

perexg · 2025-01-27T15:37:14Z

ucm2/sof-soundwire/sof-soundwire.conf

+# For SoundWire PC with PCH-DMIC set BootSequence and FixedBootSequence for eqiir, tdfb, drc
+Macro.Dmic0ArrayIir.SofEqBootSetup "endpoint='Dmic0' direction='Capture' eqtype='Iir'"
+Macro.Dmic0ArrayDrc.SofDrcBootSetup "endpoint='Dmic0' direction='Capture'"
+Macro.Dmic0ArrayTdfb.SofBeamformerBootSetup "endpoint=Dmic0 direction=Capture"


Nitpicking: Use 'STR' everywhere or remove '' everywhere.

Thanks, this is fixed too.

This patch cleans up definitions in preparation to add more controlled processing for audio endpoints. - The algorithms names write style is aligned to e.g. "Iir" instead of "IIR" and "Iir" to avoid mistakes from typos. - Add prefix PostMixerAnalogPlayback to HDA analog playback blob names to separate them from other Speaker endpoints. - Similarly rename SofControl macro. The functionality is not changed. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

This change adds a few blobs to use with SOF TDFB beamformer and updates the instructions how to generate the blobs in SOF. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

This patch enables the SOF microphone capture pre-processing features as BootSequence initial values if the controls for them are available. If the user later switches these off, they will remain off. The DRC is dynamic range control that boosts the capture level, and the TDFB (time-domain fixed beamformer) improves capture signal-to-noise ratio for set beam angle direction. The used 0 degrees angle is defined as angle towards notebook computer user. The generic blobs in topology can be replaced with device specific blobs based on DMI ID. See ucm2/blobs/sof/product_configs and ucm2/blobs/sof/user_configs. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

This patch enables SOF post-processing for soundwire speaker output. The DRC processing is enabled as BootSequence, and setup of DRC, IIR, and FIR equalizer blobs as FixedBootSeqeuence by DMI ID if custom blobs have been defined for the device in ucm2/blobs/sof/product_configs or ucm2/blobs/sof/user_configs. The DRC can be turned off permanently by user space if not desired since BootSequence is only used for first time UCM2 start. The DRC, IIR, FIR blobs are set as FixedBootSequence only if custom blobs are defined. Otherwise the blobs defined in topology remain in use. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

This patch enables as BootSequence the DRC and multi-microphone beamformer processing with the supplied blobs in topology. The enable is for defaults if there is no previous control state. The user can permanently switch off them if needed. If DMI ID based customization can done with scripts in blobs/sof/product_configs or blobs/sof/user_configs. If the blob file names are not empty the blobs are applied by UCM2 as FixedBootSequence in every boot to replace topology defaults. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

The SoundWire PCs with PCH-DMIC use the top level sof-soundwire.conf. This patch adds similar Dmic0 end-point processing enable as done in for DMIC in HDA codec PCs if the controls for processing exist. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

This patch cleans up definitions in preparation to add more controlled processing for audio endpoints. - The algorithms names write style is aligned to e.g. "Iir" instead of "IIR" and "Iir" to avoid mistakes from typos. - Add prefix PostMixerAnalogPlayback to HDA analog playback blob names to separate them from other Speaker endpoints. - Similarly rename SofControl macro. The functionality is not changed. Closes: #481 Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>

This change adds a few blobs to use with SOF TDFB beamformer and updates the instructions how to generate the blobs in SOF. Closes: #481 Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>

This patch enables the SOF microphone capture pre-processing features as BootSequence initial values if the controls for them are available. If the user later switches these off, they will remain off. The DRC is dynamic range control that boosts the capture level, and the TDFB (time-domain fixed beamformer) improves capture signal-to-noise ratio for set beam angle direction. The used 0 degrees angle is defined as angle towards notebook computer user. The generic blobs in topology can be replaced with device specific blobs based on DMI ID. See ucm2/blobs/sof/product_configs and ucm2/blobs/sof/user_configs. Closes: #481 Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>

This patch enables SOF post-processing for soundwire speaker output. The DRC processing is enabled as BootSequence, and setup of DRC, IIR, and FIR equalizer blobs as FixedBootSeqeuence by DMI ID if custom blobs have been defined for the device in ucm2/blobs/sof/product_configs or ucm2/blobs/sof/user_configs. The DRC can be turned off permanently by user space if not desired since BootSequence is only used for first time UCM2 start. The DRC, IIR, FIR blobs are set as FixedBootSequence only if custom blobs are defined. Otherwise the blobs defined in topology remain in use. Closes: #481 Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>

This patch enables as BootSequence the DRC and multi-microphone beamformer processing with the supplied blobs in topology. The enable is for defaults if there is no previous control state. The user can permanently switch off them if needed. If DMI ID based customization can done with scripts in blobs/sof/product_configs or blobs/sof/user_configs. If the blob file names are not empty the blobs are applied by UCM2 as FixedBootSequence in every boot to replace topology defaults. Closes: #481 Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>

The SoundWire PCs with PCH-DMIC use the top level sof-soundwire.conf. This patch adds similar Dmic0 end-point processing enable as done in for DMIC in HDA codec PCs if the controls for processing exist. Closes: #481 Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>

This patch moves SOF control blobs related variables set are to a new dsp.conf that is included from top level sof-hda-dsp.conf. The change allows to use the variables in InitBootSequence for the controls. E.g. customize the default blobs applied based on DMI ID of the device. There's no change to functionality in this patch. Closes: alsa-project#481 Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>

This patch cleans up definitions in preparation to add more controlled processing for audio endpoints. - The algorithms names write style is aligned to e.g. "Iir" instead of "IIR" and "Iir" to avoid mistakes from typos. - Add prefix PostMixerAnalogPlayback to HDA analog playback blob names to separate them from other Speaker endpoints. - Similarly rename SofControl macro. The functionality is not changed. Closes: alsa-project#481 Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>

This change adds a few blobs to use with SOF TDFB beamformer and updates the instructions how to generate the blobs in SOF. Closes: alsa-project#481 Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>

This patch enables the SOF microphone capture pre-processing features as BootSequence initial values if the controls for them are available. If the user later switches these off, they will remain off. The DRC is dynamic range control that boosts the capture level, and the TDFB (time-domain fixed beamformer) improves capture signal-to-noise ratio for set beam angle direction. The used 0 degrees angle is defined as angle towards notebook computer user. The generic blobs in topology can be replaced with device specific blobs based on DMI ID. See ucm2/blobs/sof/product_configs and ucm2/blobs/sof/user_configs. Closes: alsa-project#481 Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>

This patch enables SOF post-processing for soundwire speaker output. The DRC processing is enabled as BootSequence, and setup of DRC, IIR, and FIR equalizer blobs as FixedBootSeqeuence by DMI ID if custom blobs have been defined for the device in ucm2/blobs/sof/product_configs or ucm2/blobs/sof/user_configs. The DRC can be turned off permanently by user space if not desired since BootSequence is only used for first time UCM2 start. The DRC, IIR, FIR blobs are set as FixedBootSequence only if custom blobs are defined. Otherwise the blobs defined in topology remain in use. Closes: alsa-project#481 Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>

This patch enables as BootSequence the DRC and multi-microphone beamformer processing with the supplied blobs in topology. The enable is for defaults if there is no previous control state. The user can permanently switch off them if needed. If DMI ID based customization can done with scripts in blobs/sof/product_configs or blobs/sof/user_configs. If the blob file names are not empty the blobs are applied by UCM2 as FixedBootSequence in every boot to replace topology defaults. Closes: alsa-project#481 Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>

The SoundWire PCs with PCH-DMIC use the top level sof-soundwire.conf. This patch adds similar Dmic0 end-point processing enable as done in for DMIC in HDA codec PCs if the controls for processing exist. Closes: alsa-project#481 Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>

singalsu commented Dec 3, 2024

View reviewed changes

ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf Outdated Show resolved Hide resolved

singalsu force-pushed the sof_intel_dmic_boot_enable_drc_tdfb branch from ac9367a to f6c7a52 Compare December 4, 2024 17:26

singalsu marked this pull request as ready for review December 4, 2024 17:29

perexg reviewed Dec 5, 2024

View reviewed changes

ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf Outdated Show resolved Hide resolved

singalsu force-pushed the sof_intel_dmic_boot_enable_drc_tdfb branch from f6c7a52 to c84628b Compare December 5, 2024 17:44

singalsu commented Dec 5, 2024

View reviewed changes

ucm2/Intel/sof-hda-dsp/dsp.conf Outdated Show resolved Hide resolved

singalsu force-pushed the sof_intel_dmic_boot_enable_drc_tdfb branch from c84628b to 7c8231b Compare December 5, 2024 17:57

singalsu requested a review from perexg December 5, 2024 18:00

singalsu commented Dec 10, 2024

View reviewed changes

ucm2/blobs/sof/ipc4/drc/README.md Show resolved Hide resolved

singalsu force-pushed the sof_intel_dmic_boot_enable_drc_tdfb branch from 7c8231b to 9fc75f8 Compare December 10, 2024 12:14

singalsu commented Dec 10, 2024

View reviewed changes

ucm2/Intel/sof-hda-dsp/dsp.conf Outdated Show resolved Hide resolved

singalsu commented Dec 10, 2024

View reviewed changes

ucm2/Intel/sof-hda-dsp/dsp.conf Outdated Show resolved Hide resolved

singalsu force-pushed the sof_intel_dmic_boot_enable_drc_tdfb branch from 9fc75f8 to 5010678 Compare December 13, 2024 18:06

singalsu marked this pull request as draft December 13, 2024 18:09

singalsu force-pushed the sof_intel_dmic_boot_enable_drc_tdfb branch from 5010678 to 6094159 Compare December 16, 2024 14:48

singalsu marked this pull request as ready for review December 16, 2024 14:49

singalsu changed the title ~~UCM2: Intel: sof-hda-dsp: Enable Dmic0 DRC and TDFB pre-processing~~ UCM2: Intel: sof-hda-dsp: Enable Dmic0 pre-processing and SDW speaker post-processing Dec 16, 2024

singalsu force-pushed the sof_intel_dmic_boot_enable_drc_tdfb branch from 6094159 to 93e9553 Compare December 17, 2024 13:44

singalsu commented Dec 17, 2024

View reviewed changes

ucm2/Intel/sof-hda-dsp/dsp.conf Outdated Show resolved Hide resolved

kv2019i approved these changes Dec 18, 2024

View reviewed changes

ujfalusi reviewed Dec 19, 2024

View reviewed changes

ucm2/Intel/sof-hda-dsp/dsp.conf Show resolved Hide resolved

ucm2/Intel/sof-hda-dsp/dsp.conf Outdated Show resolved Hide resolved

ucm2/Intel/sof-hda-dsp/dsp.conf Show resolved Hide resolved

ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf Outdated Show resolved Hide resolved

singalsu commented Dec 19, 2024

View reviewed changes

ucm2/sof-soundwire/sof-soundwire.conf Show resolved Hide resolved

singalsu force-pushed the sof_intel_dmic_boot_enable_drc_tdfb branch from 93e9553 to a624137 Compare December 19, 2024 11:56

singalsu requested a review from ujfalusi December 19, 2024 11:57

ujfalusi approved these changes Dec 19, 2024

View reviewed changes

singalsu force-pushed the sof_intel_dmic_boot_enable_drc_tdfb branch from a624137 to 9ba5aaa Compare January 24, 2025 17:14

singalsu force-pushed the sof_intel_dmic_boot_enable_drc_tdfb branch from 9ba5aaa to 40cff31 Compare January 24, 2025 17:28

perexg requested changes Jan 27, 2025

View reviewed changes

singalsu added 6 commits January 28, 2025 12:27

UCM2: Blobs/SOF/IPC4: Add Beamformer blobs, update README.md

deef065

This change adds a few blobs to use with SOF TDFB beamformer and updates the instructions how to generate the blobs in SOF. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

singalsu force-pushed the sof_intel_dmic_boot_enable_drc_tdfb branch from 40cff31 to b4e68a4 Compare January 28, 2025 11:30

singalsu requested a review from perexg January 28, 2025 11:31

perexg closed this in 969c87e Jan 29, 2025

UCM2: Intel: sof-hda-dsp: Enable Dmic0 pre-processing and SDW speaker post-processing #481

UCM2: Intel: sof-hda-dsp: Enable Dmic0 pre-processing and SDW speaker post-processing #481

Uh oh!

Conversation

singalsu commented Dec 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

singalsu commented Dec 13, 2024

Uh oh!

singalsu commented Dec 17, 2024

Uh oh!

Uh oh!

ujfalusi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

singalsu commented Jan 13, 2025

Uh oh!

singalsu commented Jan 24, 2025

Uh oh!

singalsu commented Jan 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants