feat: support scrollToBottom in useSendFollowUpMessage#611
Draft
Jean-crack wants to merge 1 commit intoalpic-ai:mainfrom
Draft
feat: support scrollToBottom in useSendFollowUpMessage#611Jean-crack wants to merge 1 commit intoalpic-ai:mainfrom
Jean-crack wants to merge 1 commit intoalpic-ai:mainfrom
Conversation
Contributor
|
did you run it locally @Jean-crack ? |
Contributor
Author
|
Yes — I ran the targeted checks locally before opening this. Passing locally:
The failing CI job looks unrelated to this PR: |
Contributor
|
@Jean-crack CI fails |
Contributor
Author
|
Investigated this:
So this looks flaky rather than caused by the actual Most suspicious spots in
I’d suggest:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scrollToBottomsupport touseSendFollowUpMessageChanges
SendFollowUpMessageOptionswithscrollToBottom?: booleanAdaptor.sendFollowUpMessage(prompt, options?)window.openai.sendFollowUpMessagecan receivescrollToBottomuseSendFollowUpMessageto accept optional optionsTesting
pnpm exec vitest run src/web/hooks/use-send-follow-up-message.test.tspnpm --filter skybridge test:typepnpm --filter skybridge test:formatNotes
Fixes #512