Change [document type - news articles] workflow updates [WHIT-2812] #10976
+71
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpatrickpatrick
changed the title
patrickpatrickpatrick
force-pushed
the
change-workflow-updates
branch
4 times, most recently
from
1fce95a to
026290e
Compare
patrickpatrickpatrick
force-pushed
the
change-workflow-updates
branch
from
65a5c6b to
fe19ec0
Compare
Ensure consistency in copy across Whitehall by replacing instances of “ and ” with '. Replace `govspeak_to_html` call with the Inset component (to ensure that correct quote characters are used) within `editions#edit`.
patrickpatrickpatrick
force-pushed
the
change-workflow-updates
branch
from
fe19ec0 to
8df1750
Compare
Requested copy ammendments for interface when user changes the document type. Includes: - changing the title to `Review document type change` from `Preview document type change` - changing how lost associations and properties are displayed - changing how new associations and properties are displayed - rewording notice that there are no changes that will be made to the associations of a document - rewording notice that there are no changes that will be made to the properties of a document and updating the associated tests that referenced old copy.
patrickpatrickpatrick
force-pushed
the
change-workflow-updates
branch
from
8df1750 to
fdf8e0c
Compare
patrickpatrickpatrick
force-pushed
the
change-workflow-updates
branch
from
2a293f6 to
8359a7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Amendment to the copy on screens to edit the document type of a configurable document. These include:
“and”with'Review document type changefromPreview document type changefrom a document of requested changes.
Visual Differences
Why
Requested by IA to ensure consistency in copy across Whitehall.
This application is owned by the Whitehall Experience team. Please let us know in #govuk-whitehall-experience-tech when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.