Merged
Conversation
This is causing issues when trying to upgrade activesupport (from versions with security vulnerabilities) as `middleman` v4.5.1 requires `activesupport` < 7.1. The issue was resolved in v4.6.1 https://github.com/middleman/middleman/blob/main/CHANGELOG.md#461 Co-authored-by: Aga Dufrat <aga.dufrat@digital.cabinet-office.gov.uk>
a1e0059 to
24f727b
Compare
jamescarr28
approved these changes
Mar 30, 2026
brucebolt
reviewed
Mar 30, 2026
Member
brucebolt
left a comment
There was a problem hiding this comment.
Looks good to me, but the [WIP] from the commit message will need removing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is causing issues when trying to upgrade activesupport (from versions with security vulnerabilities) as
middlemanv4.5.1 requiresactivesupport< 7.1.The issue was resolved in v4.6.1
https://github.com/middleman/middleman/blob/main/CHANGELOG.md#461
It has been tested by serving https://github.com/alphagov/govuk-content-api-docs locally using this branch.