Merged
Conversation
added 3 commits
November 11, 2019 11:59
Configred redirects in config/tech-docs.yml according to https://tdt-documentation.london.cloudapps.digital/amend_project/configuration/#redirects
This is to make the URLs consistent with what they were before the restructuring, which also means the redirects will now work as they should.
Contributor
|
I agree with setting up the redirects in case of any external links, but given we know the new URL would it make sense to update the broken links to go to the correct place, rather than 'via' the redirect? Saves a round-trip to the server, and avoids confusing folk who are editing in the future! |
Author
|
Yup, totally agree about fixing the links @36degrees - |
jonathanglassman
approved these changes
Nov 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Changing the information architecture as part of #97 meant that some links broke.
Changes proposed in this pull request
The scope of this PR is to redirect broken links so that links to the old pages don't return 404s, but take the user to the right place in the new information architecture.
I'm using the list @36degrees put together in issue #105 to keep track of the work:
https://tdt-documentation.london.cloudapps.digital/amend_project/configuration/docs/frontmatter.mdnever existed as a link - it's always been wrong and it was never picked up because we don't have a link checker in place (yet!). Setting up a link checker is out of scope for this PR. There's a separate PR that adds the link checker and fixes the links: #107 😁The broken image links apply when opening the link in a new tab. The images appear correctly in the page.
Closes #105
Guidance to review
Check the redirects work as described.