Drop support for the [embed:link:<content_id>] syntax#466
Draft
ChrisBAshton wants to merge 2 commits intomainfrom
Draft
Drop support for the [embed:link:<content_id>] syntax#466ChrisBAshton wants to merge 2 commits intomainfrom
[embed:link:<content_id>] syntax#466ChrisBAshton wants to merge 2 commits intomainfrom
Conversation
This was [added in 2016](https://github.com/alphagov/govspeak/pull/83C) but doesn't appear to ever have been used. [Recent analysis in Whitehall](https://docs.google.com/spreadsheets/d/1ps58qqD0zgbWR-H0K6jmWJM-KhYBl6JApi5ZawOxmeU/edit?pli=1&gid=0#gid=0) shows zero usage in the wild. A re-run of the analysis also shows zero matched documents in Whitehall, through running: ``` rake 'reporting:matching_docs[embed:link]' ``` (as per https://docs.publishing.service.gov.uk/manual/find-usage-of-govspeak-in-content.html) Given the feature was allegedly brought into govspeak to retain feature parity with Whitehall (according to the changelog entry for v4.0.0), the absence of the syntax from any Whitehall content should give us reasonable confidence that the feature is not in use anywhere. Therefore we are removing this feature as it is unnecessary.
ChrisBAshton
force-pushed
the
remove-unused-embed_link-syntax
branch
3 times, most recently
from
401a7d4 to
7550cc8
Compare
Technically a breaking change, but given the due diligence applied in the previous commit, this shouldn't break things for anybody. It seems overkill to go for a major version increase as a result. So, minor bump here (a patch, conversely, feels too small).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added in 2016 but doesn't appear to ever have been used.
Recent analysis in Whitehall shows zero usage in the wild. A re-run of the analysis also shows zero matched documents in Whitehall, through running:
(as per https://docs.publishing.service.gov.uk/manual/find-usage-of-govspeak-in-content.html)
Given the feature was allegedly brought into govspeak to retain feature parity with Whitehall (according to the changelog entry for v4.0.0), the absence of the syntax from any Whitehall content should give us reasonable confidence that the feature is not in use anywhere.
Therefore we are removing this feature as it is unnecessary.
This repo is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.