Add GitHub Actions CI and fix build compatibility issues #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds GitHub Actions CI to automatically build and test the project, and fixes several compatibility issues that prevented the project from building with modern toolchains.
Motivation
The repository did not have automated CI, making it unclear whether the project still builds with modern versions of GHC, Cabal, and system libraries. This PR answers that question definitively: yes, it builds (with some necessary fixes).
Changes
GitHub Actions CI Workflow
Added
.github/workflows/ci.ymlthat:libquickfix-dev)Haskell Compatibility Fixes
Type family constraints - Modern GHC (9.12+) requires
UndecidableInstanceswhen using type families in constraints:{-# LANGUAGE UndecidableInstances #-}tosrc/AlphaHeavy/QuickFIX/GReceive.hs{-# LANGUAGE UndecidableInstances #-}tosrc/AlphaHeavy/QuickFIX/GSend.hsTime library API change - The
timelibrary deprecatedparseTimein favor ofparseTimeM:src/AlphaHeavy/QuickFIX/GetMessageField.hsto useparseTimeM Trueinstead ofparseTimeC++ Compatibility Fixes
C++ standard - The QuickFIX library uses dynamic exception specifications, which were deprecated in C++11 and removed in C++17:
-optcxx-std=c++11to GHC options inalphaheavy-quickfix.cabalto compile C++ code with C++11 standardMissing return statement:
sessionStringfunction incbits/QuickFIXThunks.cppto return the result ofstrdupBuild Configuration
dist-newstyle/to.gitignoreto exclude modern Cabal build artifactsTesting
The project now builds successfully with:
libquickfix-devfrom aptAll changes are minimal and focused on compatibility without altering functionality.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.