Skip to content

Conversation

@Diizzee
Copy link

@Diizzee Diizzee commented Feb 18, 2021

  • Mech option has been added to the UI
  • Mech unit is now calculated as part of Ground Combat
  • POK Factions added to drop down
  • POK Faction specific Flagships now taken into calculation for space combat
  • POK Faction specific Units now included in calculation for space combat and ground combat
  • Titans of Ul PDS are now included in ground combat.

@Diizzee
Copy link
Author

Diizzee commented Feb 18, 2021

When I first ran the changes the page threw JavaScript error as there was no Mech in the localStorage when getPersistedInput was called. I cleared my browser cache to fix it my end and the error no longer occurs. Do you know of a better way to handle this without the user having to clear cache?

@Diizzee Diizzee changed the title Add Mechs to Ground Combat Calculation Added POK Factions, their specific flagships and Standard Mechs to Calculator Feb 18, 2021
@alpha-mouse
Copy link
Owner

@Diizzee Hi, thanks very much for your input, together we'll definitely do this faster!
In this repo I'll be pushing changes related to PoK to prophecy-of-kings branch.
I've fixed loading from local storage issue that you had.
Also, I believe there should have been Ul's RaceSpecificUpgrade to Cruiser and they'll have Sustain Damage.

@Diizzee
Copy link
Author

Diizzee commented Feb 19, 2021

That's great thank you.
You're absolutely right about Ul's cruiser! I'll add that shortly.

@Diizzee
Copy link
Author

Diizzee commented Feb 19, 2021

@alpha-mouse thanks for the feedback, I've added the Ul cruiser to the PR.

@alpha-mouse
Copy link
Owner

@Diizzee just in case so we wouldn't be doing the same work twice, tomorrow I plan to work on special properties of Mechs.

@alpha-mouse
Copy link
Owner

I've merged your changes so far into the ongoing prophecy-of-kings branch.
How would you like me to mention you in credits? Just by name or maybe with email/website?

@Diizzee
Copy link
Author

Diizzee commented Mar 18, 2021

By name is fine thanks 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants