updates from main

.github/workflows/regular-checks.yaml

@@ -0,0 +1,47 @@
+# Workflow derived from https://github.com/r-lib/actions/tree/v2/examples
+# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
+on:
+  schedule:
+    - cron: '34 6 * * 1'
+
+name: regular-checks.yaml
+
+permissions: read-all
+
+jobs:
+  R-CMD-check:
+    runs-on: ${{ matrix.config.os }}
+
+    name: ${{ matrix.config.os }} (${{ matrix.config.r }})
+
+    strategy:
+      fail-fast: false
+      matrix:
+        config:
+          - {os: windows-latest, r: 'release'}
+          - {os: ubuntu-latest,   r: 'devel', http-user-agent: 'release'}
+
+    env:
+      GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
+      R_KEEP_PKG_SOURCE: yes
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: r-lib/actions/setup-pandoc@v2
+
+      - uses: r-lib/actions/setup-r@v2
+        with:
+          r-version: ${{ matrix.config.r }}
+          http-user-agent: ${{ matrix.config.http-user-agent }}
+          use-public-rspm: true
+
+      - uses: r-lib/actions/setup-r-dependencies@v2
+        with:
+          extra-packages: any::rcmdcheck
+          needs: check
+
+      - uses: r-lib/actions/check-r-package@v2
+        with:
+          upload-snapshots: true
+          build_args: 'c("--no-manual","--compact-vignettes=gs+qpdf")'

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: getRad
 Title: Download Radar Data for Biological Research
-Version: 0.2.2.9000
+Version: 0.2.3.9000
 Authors@R: c(
     person("Bart", "Kranstauber", , "b.kranstauber@uva.nl", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0001-8303-780X", affiliation = "University of Amsterdam")),

NEWS.md

@@ -1,5 +1,11 @@
 # getRad (development version)
 
+* Make error messages more consistent (#146).
+* Restore access to Estonian data.
+* Prevent leaving temporary files for downloading Dutch polar volume data (#148).
+
+# getRad 0.2.3
+
 * Improve error for requesting German data out of temporal restrictions (#131).
 * Start using the air formatter (#128).
 * Do not fail but rather warn when csv is missing from repository (#136).

R/get_pvol.R

@@ -41,15 +41,15 @@ get_pvol <- function(radar = NULL, datetime = NULL, ...) {
   check_odim_nexrad(radar)
   if (anyDuplicated(radar)) {
     cli::cli_abort(
-      "The argument {.arg radar} contains duplications these should be removed.",
+      "{.arg radar} contains duplications that must be removed.",
       class = "getRad_error_radar_duplicated"
     )
   }
   if (inherits(datetime, "POSIXct") && length(datetime) == 2) {
     if (any(duplicated(datetime))) {
       cli::cli_abort(
-        "When providing two {.cls POSIXct} as a {.arg datetime}
-                     they should differ to represent an inverval.",
+        "{.arg datetime} contains duplicate {.cls POSIXct}. Values must differ
+         to represent an interval.",
         class = "getRad_error_duplicated_timestamps"
       )
     }
@@ -61,9 +61,8 @@ get_pvol <- function(radar = NULL, datetime = NULL, ...) {
       !rlang::is_scalar_vector(datetime)
   ) {
     cli::cli_abort(
-      "The argument {.arg datetime} to the {.fn get_pvol} function
-                   should be a single {.cls POSIXct} or a {.cls interval}.
-                   The later can also be specified by two {.cls POSIXct}.",
+      "{.arg datetime} should be a single {.cls POSIXct} or a {.cls interval}.
+       The latter can also be specified by two {.cls POSIXct}.",
       class = "getRad_error_time_not_correct"
     )
   }
@@ -88,10 +87,10 @@ get_pvol <- function(radar = NULL, datetime = NULL, ...) {
   if (lubridate::is.interval(datetime)) {
     if (lubridate::as.duration(datetime) > lubridate::hours(1)) {
       cli::cli_warn(
-        "The interval specified for {.arg datetime} ({.val {lubridate::int_start(datetime)}}-{.val {lubridate::int_end(datetime)}}) likely results
-                    in many polar volumes, when loading that may polar
-                    volumes at the same time computational issues frequently
-                    occur.",
+        "{.arg datetime} represent an interval ({.val
+         {lubridate::int_start(datetime)}}-{.val {lubridate::int_end(datetime)}})
+         that likely covers many polar volumes. Computational issues can occur
+         when loading that many polar volumes at the same time.",
         class = "getRad_warn_many_pvols_requested"
       )
     }
@@ -148,7 +147,7 @@ select_get_pvol_function <- function(radar, ..., call = rlang::caller_env()) {
   ))
   if (rlang::is_na(fun)) {
     cli::cli_abort(
-      "No suitable function exist downloading from the radar {.val {radar}}",
+      "No suitable function exist to download data for radar {.val {radar}}.",
       class = "getRad_error_no_function_for_radar_with_country_code",
       call = call
     )

R/get_pvol_de.R

@@ -50,11 +50,12 @@ get_pvol_de <- function(radar, time, ..., call = rlang::caller_env()) {
   if (nrow(files_to_get) != 50) {
     cli::cli_abort(
       c(
-        x = "The server returned an unexpected number of files.",
-        i = "In many cases this because no data is available for the time requested. For Germany only the last three days are available.",
-        i = "Alternatively there is an unstable connection or temporal error in the German data provided."
+        "The server returned an unexpected number of files.",
+        "i" = "In many cases this because no data are available for the time
+               requested. For Germany only the last three days are available.
+               The error can also be caused by an unstable connection or
+               temporal error in the German data provided."
       ),
-
       class = "getRad_error_germany_unexpected_number_of_files",
       call = call
     )

R/get_pvol_ee.R

@@ -31,13 +31,13 @@ get_pvol_ee <- function(radar, time, ..., call = rlang::caller_env()) {
                         list(
                           greaterThanOrEqual = list(
                             field = "Timestamp",
-                            value = strftime(time, "%Y-%m-%dT%H:%M:%OS6%z")
+                            value = strftime(time, "%FT%TZ", tz = 'UTC')
                           )
                         ),
                         list(
                           lessThanOrEqual = list(
                             field = "Timestamp",
-                            value = strftime(time, "%Y-%m-%dT%H:%M:%OS6%z")
+                            value = strftime(time, "%FT%TZ", tz = "UTC")
                           )
                         )
                       )
@@ -62,7 +62,7 @@ get_pvol_ee <- function(radar, time, ..., call = rlang::caller_env()) {
       )
     )
   files <- httr2::request(
-    "https://avaandmed.keskkonnaportaal.ee/_vti_bin/RmApi.svc/active/items/query"
+    "https://avaandmed.keskkonnaportaal.ee/api/lists/active/items/query"
   ) |>
     req_user_agent_getrad() |>
     httr2::req_body_json(json_list) |>
@@ -71,7 +71,7 @@ get_pvol_ee <- function(radar, time, ..., call = rlang::caller_env()) {
     httr2::resp_body_json()
   if (files$numFound == 0 || length(files$documents) != 1) {
     cli::cli_abort(
-      "The expected number of files is not found",
+      "The expected number of files is not found.",
       class = "getRad_error_get_pvol_ee_differing_n_files"
     )
   }

R/get_pvol_nl.R

@@ -7,11 +7,17 @@ get_pvol_nl <- function(radar, time, ..., call = rlang::caller_env()) {
   if (converter == "") {
     cli::cli_abort(
       c(
-        x = "The program to convert KNMI data to ODIM format is not found.",
-        i = "The source code for this binary can be obtained from this location {.file {system.file('extra/KNMI_vol_h5_to_ODIM_h5.c', package='getRad')}}",
-        i = "Please compile the binary and include it in the search path as a program named {.arg KNMI_vol_h5_to_ODIM_h5}",
-        i = "On linux systems this can be done with the following command {.code h5cc KNMI_vol_h5_to_ODIM_h5.c -o KNMI_vol_h5_to_ODIM_h5}.",
-        i = "If another name is used or the program is not in the search path use options to locate the program ({.run options(getRad.nl_converter='')})."
+        "The program to convert KNMI data to the ODIM format can't be found.",
+        "i" = "The source code for this binary can be obtained from {.file
+                 {system.file(\"extra/KNMI_vol_h5_to_ODIM_h5.c\",
+                 package=\"getRad\")}}.",
+        "i" = "Please compile the binary and include it in the search path as
+                 a program named {.val KNMI_vol_h5_to_ODIM_h5}. On linux systems
+                 this can be done with the command {.code h5cc
+                 KNMI_vol_h5_to_ODIM_h5.c -o KNMI_vol_h5_to_ODIM_h5}. If another
+                 name is used or the program is not in the search path, use
+                 options to locate the program ({.code
+                 options(getRad.nl_converter=\"\")})."
       ),
       class = "getRad_error_no_nl_converter_found",
       call = call
@@ -55,8 +61,10 @@ get_pvol_nl <- function(radar, time, ..., call = rlang::caller_env()) {
     httr2_http_403 = function(cnd) {
       cli::cli_abort(
         c(
-          "There was an authorization error, possibly this relates to using an invalid API key",
-          i = "Please check if you set the correct `nl_api_key` with {.code get_secret('nl_api_key')}"
+          "There was an authorization error. You may have used an invalid API
+           key.",
+          "i" = "Please check if you set the correct {.val nl_api_key} with
+                 {.code get_secret(\"nl_api_key\")}."
         ),
         cnd = cnd,
         class = "getRad_error_get_pvol_nl_authorization_failure",
@@ -70,7 +78,8 @@ get_pvol_nl <- function(radar, time, ..., call = rlang::caller_env()) {
       httr2::req_url(req = resp$request) |>
       httr2::req_headers(Authorization = NULL) |>
       httr2::req_perform(path = file, error_call = call)
-    pvol_path <- paste0(req$body, ".odim.h5")
+
+  withr::with_tempfile("pvol_path", fileext = ".odim.h5", {
     system(
       paste(converter, pvol_path, req$body),
       ignore.stdout = TRUE,
@@ -79,13 +88,17 @@ get_pvol_nl <- function(radar, time, ..., call = rlang::caller_env()) {
     if (!file.exists(pvol_path)) {
       cli::cli_abort(
         c(
-          x = "The converter for the Netherland has not generated the output file.",
-          i = "Using {.file {converter}} an attempt was made to convert {.file {req$body}} to the odim format. Most likely the converter is incorrect."
-        ),
-        class = "getRad_error_dutch_converter_failed"
-      )
-    }
-    bioRad::read_pvolfile(pvol_path, ...)
+          x = "The converter for the Netherland has not generated the expected 
+output file.",
+            i = "Using {.file {converter}} an attempt was made to convert 
+{.file {req$body}} to the odim format. Most likely the 
+converter is incorrect."
+          ),
+          class = "getRad_error_dutch_converter_failed"
+        )
+      }
+      bioRad::read_pvolfile(pvol_path, ...)
+    })
   })
   return(pvol)
 }

R/get_pvol_se.R

@@ -62,9 +62,10 @@ get_pvol_se <- function(radar, time, ..., call = rlang::caller_env()) {
       httr2_http_404 = function(cnd) {
         cli::cli_abort(
           c(
-            x = "No polar volume data could be found for {.val {radar}} at time {.val {time}}",
-            i = "Volume data in Sweden is only available for 24 hours",
-            i = "If the requested time is within the last 24 hours the error might relate to a server outage or package problem"
+            "Can't find polar volume data for {.val {radar}} at {.val {time}}.",
+            "i" = "Polar volume data in Sweden is only available for 24 hours.
+                   If the requested time is within the last 24 hours the error
+                   might relate to a server outage or package problem."
           ),
           parent = cnd,
           call = call,

R/get_pvol_us.R

@@ -18,7 +18,7 @@ get_pvol_us <- function(radar, datetime, ..., call = rlang::caller_env()) {
           httr2::req_perform(path = file, error_call = call),
         httr2_http_404 = function(cnd) {
           cli::cli_abort(
-            "NEXRAD file not found at {.url {url}}.",
+            "Can't find NEXRAD file at {.url {url}}.",
             call = call,
             cnd = cnd,
             class = "getRad_error_us_file_not_found"
@@ -48,8 +48,7 @@ get_pvol_us <- function(radar, datetime, ..., call = rlang::caller_env()) {
   d <- as.Date(date, tz = "UTC")
   if (!rlang::is_scalar_character(radar)) {
     cli::cli_abort(
-      "Radar should be a character of length one as otherwise not all
-                   key date combinations might be tried",
+      "{.arg radar} must be single radar code.",
       class = "getRad_error_pvol_us_radar_not_scalar",
       call = call
     )
@@ -145,7 +144,8 @@ get_pvol_us <- function(radar, datetime, ..., call = rlang::caller_env()) {
   )
   if (!length(ts)) {
     cli::cli_abort(
-      "No scans found for {.val {radar}} near {.val {format(datetime, '%F %T %Z')}}",
+      "Can't find scans for radar {.val {radar}} near {.val {format(datetime,
+       \"%F %T %Z\")}}.",
       class = "getRad_error_us_no_scan_found",
       call = call
     )

R/get_vpts.R

@@ -71,17 +71,14 @@ get_vpts <- function(
   if (missing(source)) {
     source <- "baltrad"
   }
+  supported_sources <- eval(rlang::fn_fmls()$source)
+
   if (is.null(source)) {
     # providing NULL isn't allowed either
     cli::cli_abort(
-      glue::glue(
-        "Please provide a value for the source argument:
-        possible values are {possible_sources}.",
-        possible_sources = glue::glue_collapse(
-          glue::backtick(eval(rlang::fn_fmls()$source)),
-          sep = ", ",
-          last = " or "
-        )
+      c(
+        "{.arg source} must be provided.",
+        "i" = "Supported sources: {.val {supported_sources}}."
       ),
       class = "getRad_error_source_missing"
     )
@@ -92,7 +89,7 @@ get_vpts <- function(
   ## the enumeration in the function definition.
   if (length(source) > 1) {
     cli::cli_abort(
-      "Only one source can be queried at a time.",
+      "{.arg source} must be a single character value.",
       class = "getRad_error_multiple_sources"
     )
   }
@@ -101,17 +98,11 @@ get_vpts <- function(
 
   # Get the default value of the source arg, even if the user provided
   # a different value.
-  supported_sources <- eval(formals()$source)
   if (!source %in% supported_sources) {
     cli::cli_abort(
-      glue::glue(
-        "Invalid source {glue::backtick(source)} provided. Possible values are:
-        {possible_sources}.",
-        possible_sources = glue::glue_collapse(
-          glue::backtick(supported_sources),
-          sep = ", ",
-          last = " or "
-        )
+      c(
+        "{.arg source} {.val {source}} is invalid.",
+        "i" = "Supported sources: {.val {supported_sources}}."
       ),
       class = "getRad_error_source_invalid"
     )
@@ -120,7 +111,7 @@ get_vpts <- function(
   # Check that the provided radar argument is a character vector
   if (!is.character(radar)) {
     cli::cli_abort(
-      "Radar argument must be a character vector.",
+      "{.arg radar} must be a character vector.",
       class = "getRad_error_radar_not_character"
     )
   }
@@ -132,7 +123,8 @@ get_vpts <- function(
       !lubridate::is.interval(datetime)
   ) {
     cli::cli_abort(
-      "{.arg datetime} argument must be a {.cls character}, {.cls POSIXct}, {.cls Date}, or {.cls Interval} object.",
+      "{.arg datetime} must be a {.cls character}, {.cls POSIXct}, {.cls Date},
+       or {.cls Interval} object.",
       class = "getRad_error_date_parsable"
     )
   }

R/get_vpts_aloft.R

@@ -42,8 +42,8 @@ get_vpts_aloft <- function(
   if (!all(radar_odim_code %in% coverage$radar)) {
     missing_radar <- radar_odim_code[!radar_odim_code %in% coverage$radar]
     cli::cli_abort(
-      "Radar not found in ALOFT coverage:
-      {missing_radar}.",
+      "Can't find radar {.val {missing_radar}} in the coverage file (see
+       {.fun get_vpts_coverage}).",
       missing_radar = missing_radar,
       class = "getRad_error_aloft_radar_not_found"
     )
@@ -60,7 +60,7 @@ get_vpts_aloft <- function(
 
   if (!at_least_one_radar_date_combination_exists) {
     cli::cli_abort(
-      "No data found for the requested radar(s) and date(s).",
+      "Can't find any data for the requested radar(s) and date(s).",
       class = "getRad_error_date_not_found"
     )
   }
@@ -77,9 +77,8 @@ get_vpts_aloft <- function(
 
   if (!all(radar_odim_code %in% coverage$radar)) {
     cli::cli_abort(
-      "{length(missing_radars)} Radar{?s} not found in {source} coverage:
-      {glue::backtick(missing_radars)}",
-      missing_radars = missing_radars,
+      "Can't find radar{?s} {.val {missing_radars}} in the coverage file (see
+       {.fun get_vpts_coverage}).",
       class = "getRad_error_radar_not_found"
     )
   }