Skip to content

Conversation

@bart1
Copy link
Collaborator

@bart1 bart1 commented Dec 2, 2025

No description provided.

peterdesmet and others added 22 commits November 14, 2025 14:37
@bart1 this test is failing (returns NULL rather than the radar name). Rather than fixing it, I don't see the need for this test. We don't use the catch_cnd() approach anywhere else
Fix typo + make error messages consistent
@bart1 bart1 marked this pull request as ready for review December 2, 2025 14:03
@bart1 bart1 merged commit 3d64bd0 into 135-using-local-files-as-source-in-get_vpts Dec 2, 2025
3 checks passed
@bart1 bart1 deleted the fix-merge-request branch December 2, 2025 14:03
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 78.21782% with 22 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (135-using-local-files-as-source-in-get_vpts@ff7634c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
R/utils.R 76.92% 6 Missing ⚠️
R/get_pvol.R 60.00% 4 Missing ⚠️
R/get_pvol_nl.R 78.94% 4 Missing ⚠️
R/get_pvol_us.R 50.00% 2 Missing ⚠️
R/get_vpts_aloft.R 60.00% 2 Missing ⚠️
R/get_vpts_coverage_rmi.R 50.00% 2 Missing ⚠️
R/get_pvol_ee.R 75.00% 1 Missing ⚠️
R/utils_pvol.R 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                              Coverage Diff                               @@
##             135-using-local-files-as-source-in-get_vpts     #155   +/-   ##
==============================================================================
  Coverage                                               ?   91.16%           
==============================================================================
  Files                                                  ?       25           
  Lines                                                  ?     1845           
  Branches                                               ?        0           
==============================================================================
  Hits                                                   ?     1682           
  Misses                                                 ?      163           
  Partials                                               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants