-
Notifications
You must be signed in to change notification settings - Fork 0
Fix typo + make error messages consistent #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me I made a suggestion for the url error. PS is a NEWS update needed?
|
Noticed a bunch more, now all standardized. Let's see if the checks pass. |
@bart1 this test is failing (returns NULL rather than the radar name). Rather than fixing it, I don't see the need for this test. We don't use the catch_cnd() approach anywhere else
|
@bart1 un unrelated test is failing: getRad/tests/testthat/test-get_pvol_ro.R Line 22 in 156b846
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 91.70% 92.47% +0.76%
==========================================
Files 24 24
Lines 1772 1780 +8
==========================================
+ Hits 1625 1646 +21
+ Misses 147 134 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@peterdesmet I fixed some of the testing errors any objection merging this? I think the decrease in coverage is mostly due to different formatting and error message spread over more lines |
No description provided.