Skip to content

Conversation

@peterdesmet
Copy link
Member

No description provided.

@peterdesmet peterdesmet requested a review from bart1 November 14, 2025 14:11
Copy link
Collaborator

@bart1 bart1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me I made a suggestion for the url error. PS is a NEWS update needed?

@peterdesmet
Copy link
Member Author

Noticed a bunch more, now all standardized. Let's see if the checks pass.

@bart1 this test is failing (returns NULL rather than the radar name). Rather than fixing it, I don't see the need for this test. We don't use the catch_cnd() approach anywhere else
@peterdesmet
Copy link
Member Author

@bart1 un unrelated test is failing:

pvol <- expect_s3_class(get_pvol("romed", time, param = "all"), "pvol")

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 81.44330% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.47%. Comparing base (156b846) to head (9b41845).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
R/utils.R 76.92% 6 Missing ⚠️
R/get_pvol.R 60.00% 4 Missing ⚠️
R/get_pvol_us.R 50.00% 2 Missing ⚠️
R/get_vpts_aloft.R 60.00% 2 Missing ⚠️
R/get_vpts_coverage_rmi.R 50.00% 2 Missing ⚠️
R/get_pvol_ee.R 75.00% 1 Missing ⚠️
R/utils_pvol.R 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   91.70%   92.47%   +0.76%     
==========================================
  Files          24       24              
  Lines        1772     1780       +8     
==========================================
+ Hits         1625     1646      +21     
+ Misses        147      134      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bart1
Copy link
Collaborator

bart1 commented Dec 2, 2025

@peterdesmet I fixed some of the testing errors any objection merging this?

I think the decrease in coverage is mostly due to different formatting and error message spread over more lines

@bart1 bart1 mentioned this pull request Dec 2, 2025
@bart1 bart1 merged commit 44a6252 into main Dec 2, 2025
10 of 11 checks passed
@bart1 bart1 deleted the latter branch December 2, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants