Skip to content

Conversation

@bart1
Copy link
Collaborator

@bart1 bart1 commented Oct 13, 2025

No description provided.

@bart1 bart1 linked an issue Oct 13, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.70%. Comparing base (a7e2697) to head (557997d).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   92.64%   93.70%   +1.05%     
==========================================
  Files          24       24              
  Lines        1795     1795              
==========================================
+ Hits         1663     1682      +19     
+ Misses        132      113      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bart1 bart1 requested a review from PietrH October 14, 2025 09:49
@bart1
Copy link
Collaborator Author

bart1 commented Oct 14, 2025

The reduced coverage seems to be due to a retry not being done for Swedish data.

@bart1 bart1 marked this pull request as ready for review October 14, 2025 10:25
@bart1 bart1 requested a review from peterdesmet November 18, 2025 09:25
Copy link
Member

@peterdesmet peterdesmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@bart1 bart1 merged commit 355775a into main Dec 3, 2025
15 of 36 checks passed
@bart1 bart1 deleted the 133-fail-early-on-not-finding-a-dutch-converter branch December 10, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail early on not finding a Dutch converter

3 participants