Skip to content

Conversation

@bart1
Copy link
Collaborator

@bart1 bart1 commented Oct 9, 2025

Now the vp starts at the correct altitude (same as baltrad)

devtools::load_all("~/getRad/")
#> ℹ Loading getRad
plot(bioRad::calculate_vp(get_pvol("detur",Sys.time()-1000)))
#> Running vol2birdSetUp
#> Warning: no dual-pol moments found, switching to SINGLE POL mode

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.38%. Comparing base (490052e) to head (b75660f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   92.30%   92.38%   +0.07%     
==========================================
  Files          24       24              
  Lines        1754     1772      +18     
==========================================
+ Hits         1619     1637      +18     
  Misses        135      135              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bart1 bart1 requested a review from PietrH October 10, 2025 06:39
Copy link
Contributor

@PietrH PietrH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could have done this with purrr assignment, I have no preference.

https://purrr.tidyverse.org/reference/pluck.html

I didn't do any deep testing due to time constraints.

@bart1 bart1 merged commit 1be8f54 into main Oct 10, 2025
22 of 29 checks passed
@bart1 bart1 deleted the 139-where-attribute-for-german-pvol-data-misses-correct-attributes-for-long-lat-height branch December 10, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

where attribute for german pvol data misses correct attributes for long lat height

3 participants