Skip to content

Conversation

@bart1
Copy link
Collaborator

@bart1 bart1 commented Oct 8, 2025

Should resolve the issue :

devtools::load_all("~/getRad")
#> ℹ Loading getRad
get_vpts("deisn", as.Date("2025-7-1")+27:30)
#> Warning: ! The following:
#>   https://aloftdata.s3-eu-west-1.amazonaws.com/baltrad/daily/deisn/2025/deisn_vpts_20250730.csv
#>   url could not be downloaded (HTTP 404 Not Found).
#> ℹ Given an attempt was made data was present in the coverage data. Therefore
#>   this likely relates to an error in the data repository. For now the data has
#>   been omitted from the returned result however for a final resolution the
#>   issue should be resolved in the repository (e.g.
#>   <https://github.com/aloftdata/data-repository>).
#>                    Irregular time series of vertical profiles (class vpts)
#> 
#>            radar:  deisn 
#>       # profiles:  864 
#> time range (UTC):  2025-07-28 00:00:00 - 2025-07-31 23:45:00 
#>    time step (s):  min: 0     max:  87300

@bart1 bart1 linked an issue Oct 8, 2025 that may be closed by this pull request
@bart1 bart1 requested a review from PietrH October 8, 2025 14:54
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.30%. Comparing base (4b84a26) to head (7ae4b09).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   92.21%   92.30%   +0.09%     
==========================================
  Files          24       24              
  Lines        1733     1754      +21     
==========================================
+ Hits         1598     1619      +21     
  Misses        135      135              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@PietrH PietrH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor documentation suggestions, no second review round needed.

@bart1 bart1 merged commit c03091a into main Oct 9, 2025
9 checks passed
@bart1 bart1 deleted the 136-get_vpts-fails-with-a-404-for-missing-data branch October 9, 2025 09:40
@bart1 bart1 restored the 136-get_vpts-fails-with-a-404-for-missing-data branch October 9, 2025 09:43
bart1 added a commit that referenced this pull request Oct 9, 2025
…for-missing-data

use httpbin resolve comment from #137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_vpts fails with a 404 for missing data

3 participants