Skip to content

Conversation

@bart1
Copy link
Collaborator

@bart1 bart1 commented Aug 14, 2025

No description provided.

@bart1 bart1 linked an issue Aug 14, 2025 that may be closed by this pull request
@bart1 bart1 requested a review from peterdesmet August 14, 2025 12:01
@PietrH
Copy link
Contributor

PietrH commented Aug 14, 2025

Test coverage failed, strange that R CMD CHECK didn't trip

@bart1
Copy link
Collaborator Author

bart1 commented Aug 14, 2025

Test coverage failed, strange that R CMD CHECK didn't trip

The error is a 429 on dutch data so probably not related to the package and retesting would resolve

@bart1 bart1 marked this pull request as ready for review August 14, 2025 13:40
@bart1
Copy link
Collaborator Author

bart1 commented Nov 18, 2025

@peterdesmet any objections to include this?

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.41%. Comparing base (2379fc1) to head (f5f48eb).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   92.44%   92.41%   -0.03%     
==========================================
  Files          24       24              
  Lines        1787     1781       -6     
==========================================
- Hits         1652     1646       -6     
  Misses        135      135              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@peterdesmet peterdesmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection to run regular checks. I wonder how the reporting works though: will we just have to see from a badge in the README?

@bart1
Copy link
Collaborator Author

bart1 commented Dec 2, 2025

I think I will also get emails for failed runs ?

@bart1 bart1 merged commit 367217a into main Dec 2, 2025
11 checks passed
@bart1 bart1 deleted the 106-implement-regular-checks branch December 10, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement regular checks

4 participants