Skip to content

Conversation

@tysonclugg
Copy link
Contributor

The changes to setup.py allow nose to find and use the plugin directly from the normal nosetests command line client, rather than requiring use of the special aloe client. I'd prefer that we didn't have to pass --no-ignore-python and that other tests ran by default, but that may be the subject of a different PR.

@koterpillar
Copy link
Member

I'm happy to make --ignore-python default for invocation as aloe only, not nosetests if you'd want to add that too.

@tysonclugg
Copy link
Contributor Author

I wasn't sure you'd be comfortable with the changes in #115, you may pick which one you wish to merge...

@tysonclugg
Copy link
Contributor Author

I feel like #115 is a bigger task that will be embroiled with questions and side issues. Please, can this PR be accepted now so it doesn't remain sidelined whilst #115 is decided?

It's a simple change with two big benefits:

  • Can run all tests in one command.
  • No need to combine coverage/xunit output files from multiple test runs.

@koterpillar
Copy link
Member

Makes sense, accepting this.

@koterpillar koterpillar merged commit e6dccdf into aloetesting:master Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants