Open
Conversation
moongua404
reviewed
Apr 28, 2025
| String input = view.input(""); | ||
| if (input.equals("4")) return; | ||
| Runnable action = menuMap.get(input); | ||
| if (action != null) action.run(); |
Contributor
There was a problem hiding this comment.
runnable을 선언할 필요 없이 바로 실행하는 편이 가독성이나 효율성 측면에서 더 좋을 것 같아요
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| public class printerController { |
Contributor
There was a problem hiding this comment.
클래스명은 대문자로 시작하는게 컨벤션상 좋을거같아요
| int end = Math.min(start + paperSize, input.length()); | ||
| printOneLine(input.substring(start, end)); | ||
| start = end; | ||
| } |
Contributor
There was a problem hiding this comment.
reduce를 써서 함수형 프로그래밍으로 표현할 수 있지 않을까요?
| inkManager.minusInk(); | ||
| appendAscii(lines, ch); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
이 부분도 stream API를 사용하면 더 효율적이고 가독성 높게 구성할 수 있을 것 같아요
|
|
||
| private List<StringBuilder> initLines() { | ||
| List<StringBuilder> lines = new ArrayList<>(); | ||
| for (int i = 0; i < LINE_COUNT; i++) lines.add(new StringBuilder()); |
Contributor
There was a problem hiding this comment.
이 부분이랑 아래 부분들을 함수형으로 구성하면 좋을 것 같아요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.