Open
Conversation
moongua404
reviewed
Apr 28, 2025
Contributor
moongua404
left a comment
moongua404
left a comment
There was a problem hiding this comment.
3주차 미션 수고 많으셨습니다!
미션 요구사항이랑 다른 점이 좀 많아서,... 시간 되시면 다시 한 번 해보셔도 좋을 것 같아요!
| public String getAsciiArt(int number) { | ||
| switch (number) { | ||
| case 1: | ||
| return " # \n ## \n # \n # \n ### \n"; |
Contributor
There was a problem hiding this comment.
이렇게 구현해두면 문자를 한 줄로 잇는게 힘들지 않을까요?
|
|
||
| view.printSuccess(); | ||
| showStatus(); | ||
| } |
| int number = scanner.nextInt(); | ||
|
|
||
| if (number == -1) { | ||
| System.out.println("프로그램을 종료합니다."); |
Contributor
There was a problem hiding this comment.
뷰를 분리했음에도 Application 단에서 sout을 하는게 관심사의 분리 측면에서 부적절할 수 있을 것 같아요
|
3주차 미션 수고 많으셨습니다!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ink 완료