Conversation
kokkumong
commented
May 13, 2025
kokkumong
commented
- 지피티 (많이)참고해서 했습니다.
- 지피티 (많이)참고해서 했습니다.
Huniiiiiii
reviewed
May 20, 2025
Comment on lines
+4
to
+40
| public static int add(String input) { | ||
| if (input == null || input.isEmpty()) { | ||
| return 0; | ||
| } | ||
|
|
||
| String delimiter = ",|:"; | ||
|
|
||
| if (input.startsWith("//")) { | ||
| int delimiterIndex = input.indexOf("\n"); | ||
| if (delimiterIndex == -1) { | ||
| throw new IllegalArgumentException("잘못된 구분자 형식입니다."); | ||
| } | ||
|
|
||
| String customDelimiter = input.substring(2, delimiterIndex); | ||
| if (customDelimiter.isEmpty()) { | ||
| throw new IllegalArgumentException("커스텀 구분자가 비어 있습니다."); | ||
| } | ||
|
|
||
| delimiter = customDelimiter; | ||
| input = input.substring(delimiterIndex + 1); | ||
| } | ||
|
|
||
| String[] tokens = input.split(delimiter); | ||
| int sum = 0; | ||
|
|
||
| for (String token : tokens) { | ||
| if (token.isEmpty()) continue; | ||
|
|
||
| try { | ||
| int number = Integer.parseInt(token.trim()); | ||
| sum += number; | ||
| } catch (NumberFormatException e) { | ||
| throw new IllegalArgumentException("숫자가 아닌 값이 포함되어 있습니다: " + token); | ||
| } | ||
| } | ||
|
|
||
| return sum; |
There was a problem hiding this comment.
add 하나에 너무 많은 기능이 있는 거 같아요. 의존성 분리를 하는 것을 어떨까요?
Comment on lines
+29
to
+38
| for (String token : tokens) { | ||
| if (token.isEmpty()) continue; | ||
|
|
||
| try { | ||
| int number = Integer.parseInt(token.trim()); | ||
| sum += number; | ||
| } catch (NumberFormatException e) { | ||
| throw new IllegalArgumentException("숫자가 아닌 값이 포함되어 있습니다: " + token); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.