fix(keeper): prevent clearing all active topics when removing non-existent topic #875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
Fix a bug in
inactivateTopicWithoutMinWeightResetfunction that could cause all active topics to be inadvertently cleared when attempting to remove a topic that doesn't exist in the active topics list.If
topicIdis not found in the loop (due to state inconsistency),newActiveTopicIdsremains empty, andSetBlockToActiveTopicswill clear all active topics for that block.Are these changes tested and documented?
Unreleasedsection ofCHANGELOG.md?Still Left Todo
Fill this out if this is a Draft PR so others can help.