feat: expose events on xscheduler module #870
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf Linter / buf (pull_request).
|
amimart
force-pushed
the
arnaud/design-scheduler
branch
from
a96e5b7 to
ee375bb
Compare
amimart
force-pushed
the
arnaud/engn-4255-expose-events-on-xscheduler-module
branch
from
8d3943c to
5093368
Compare
amimart
force-pushed
the
arnaud/design-scheduler
branch
from
9b9c432 to
ada7012
Compare
amimart
force-pushed
the
arnaud/engn-4255-expose-events-on-xscheduler-module
branch
from
5093368 to
c5936b1
Compare
xmariachi
previously approved these changes
Oct 20, 2025
amimart
force-pushed
the
arnaud/engn-4255-expose-events-on-xscheduler-module
branch
from
c5936b1 to
c487365
Compare
amimart
requested review from
guilherme-brandao,
spooktheducks and
zale144
as code owners
| return err | ||
| } | ||
|
|
||
| oldScheduleKey := getTaskScheduleKey(task) |
Contributor
There was a problem hiding this comment.
Usually we return the struct + err on the keeper's get methods
Contributor
Author
There was a problem hiding this comment.
Oh but the task schedule key can be nil it's not an error, but it's an impossible/forbidden case when we execute a task
zale144
approved these changes
Oct 22, 2025
Comment on lines
+484
to
+486
| evt, err := cosmostypes.ParseTypedEvent(e) | ||
| require.NoError(t, err) | ||
| parsed = append(parsed, evt) |
Contributor
There was a problem hiding this comment.
maybe consider extracting this for parsing single events, in case we might use it. maybe in a util? just a thought
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
Add the emissions of the events below in the
x/schedulermodule:TaskScheduledEvent: Emitted when a task is scheduled or rescheduled at a specific time (i.e. a task can be created without being scheduled, in that case the event is not emitted);TaskUnscheduledEvent: Emitted when a task that was scheduled, is cancelled or unscheduled;TaskExecutedEvent: Emitted when a task is executed.;Are these changes tested and documented?
Unreleasedsection ofCHANGELOG.md?