Skip to content

Cover against all listening coefficients being zero #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xmariachi wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Cover against all listening coefficients being zero #842

xmariachi wants to merge 5 commits into from
+18 −0

Conversation

@xmariachi
Copy link
Contributor

@xmariachi xmariachi commented Jul 18, 2025 •
edited
Loading

Purpose of Changes and their Description

  • Covering against the case where all coefficients are zero, setting EpsilonSafeDiv instead.

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed. -- Just by running current tests.
  • If documented, please describe where. If not, describe why docs are not needed. -- No need, just a safety measure on an existing implementation - it doesn't change the intention.
  • Added to Unreleased section of CHANGELOG.md?

@xmariachi xmariachi changed the title Cover against all coefficients being zero Cover against all listening coefficients being zero Jul 18, 2025
@xmariachi xmariachi requested a review from fstecker July 18, 2025 19:01
@xmariachi xmariachi marked this pull request as ready for review August 6, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fstecker fstecker Awaiting requested review from fstecker

@zale144 zale144 Awaiting requested review from zale144 zale144 is a code owner

@amimart amimart Awaiting requested review from amimart amimart is a code owner

@guilherme-brandao guilherme-brandao Awaiting requested review from guilherme-brandao guilherme-brandao is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xmariachi