fix typo Update keepers.go #836
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR corrects a misleading error message in the DefaultFeemarketDenomResolver.ConvertToDenom method. Previously, when coin.Denom != denom, the error message would state: the only denom supported is <coin.Denom> This was confusing, since coin.Denom is the invalid denom passed in, not the expected one. The correct behavior is to indicate that only the target denom (the denom argument) is supported. This fix improves clarity in logs and error handling for clients or developers interacting with the fee market denom resolver. The corrected message now properly reflects which denom is allowed. Signed-off-by: Moshe <154280952+moshderte@users.noreply.github.com>
Author
|
@zale144 hello sir if have time check pls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects a misleading error message in the DefaultFeemarketDenomResolver.ConvertToDenom method.
Previously, when coin.Denom != denom, the error message would state:
the only denom supported is <coin.Denom>
This was confusing, since coin.Denom is the invalid denom passed in, not the expected one. The correct behavior is to indicate that only the target denom (the denom argument) is supported.
This fix improves clarity in logs and error handling for clients or developers interacting with the fee market denom resolver. The corrected message now properly reflects which denom is allowed.