Guilherme/engn 3811 modifiable topics #831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf Linter / buf (pull_request).
|
guilherme-brandao
changed the base branch from
dev
to
alek/engn-3789-refactor-unit-tests-to-reduce-technical-debt-0
xmariachi
reviewed
Jun 16, 2025
Base automatically changed from
alek/engn-3789-refactor-unit-tests-to-reduce-technical-debt-0
to
dev
June 19, 2025 11:55
guilherme-brandao
force-pushed
the
guilherme/engn-3811-modifiable-topics
branch
from
1be79e1 to
18912c0
Compare
spooktheducks
requested changes
Jun 26, 2025
guilherme-brandao
force-pushed
the
guilherme/engn-3811-modifiable-topics
branch
from
2ee0667 to
7db5d46
Compare
xmariachi
reviewed
Nov 25, 2025
Contributor
xmariachi
left a comment
xmariachi
left a comment
There was a problem hiding this comment.
More discussion to be had about the store, for now these two comments
xmariachi
reviewed
Nov 27, 2025
amimart
reviewed
Dec 3, 2025
Contributor
amimart
left a comment
amimart
left a comment
There was a problem hiding this comment.
Nice thx! Just left some suggestions
amimart
reviewed
Dec 9, 2025
guilherme-brandao
force-pushed
the
guilherme/engn-3811-modifiable-topics
branch
from
1d6d897 to
92cdb74
Compare
amimart
reviewed
Dec 16, 2025
amimart
reviewed
Dec 16, 2025
xmariachi
requested changes
Dec 17, 2025
Contributor
xmariachi
left a comment
xmariachi
left a comment
There was a problem hiding this comment.
Small changes requested on UpdateTopic fn
zale144
reviewed
Dec 18, 2025
zale144
reviewed
Dec 19, 2025
Relates to ENGN-4064
guilherme-brandao
force-pushed
the
guilherme/engn-3811-modifiable-topics
branch
from
4b0849b to
349a845
Compare
## Purpose of Changes and their Description - Move `c_norm` from global params to a per-topic field, updating proto definitions, tx messages, keeper/msgserver logic, and synthesis/regret calculations to read from `topic.CNorm`. - Add migration v12 to drop global `c_norm` and copy the previous value into every existing topic using a store iterator to avoid gaps. ## Link(s) to Ticket(s) or Issue(s) resolved by this PR https://linear.app/alloralabs/issue/ENGN-4064/editable-per-topic-c-norm ## Are these changes tested and documented? - [x] If tested, please describe how. If not, why tests are not needed. - [x] If documented, please describe where. If not, describe why docs are not needed. - [x] Added to `Unreleased` section of `CHANGELOG.md`?
amimart
previously approved these changes
Dec 29, 2025
xmariachi
reviewed
Jan 5, 2026
xmariachi
approved these changes
Jan 6, 2026
amimart
approved these changes
Jan 6, 2026
spooktheducks
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
This PR introduces the ability for topic creators to update existing topics
UpdateTopicmessage/handler so topic creators can update metadata and selected tuning parameters.TopicUpdatedevent whenever a topic change is applied.Link(s) to Ticket(s) or Issue(s) resolved by this PR
https://linear.app/alloralabs/issue/ENGN-3811/modifiable-topics
Are these changes tested and documented?
Unreleasedsection ofCHANGELOG.md?