Conversation
Member
thelostone-mc
left a comment
thelostone-mc
left a comment
There was a problem hiding this comment.
left a few questions but otherwise lgtm
| /// @notice Stores the details of the recipients. | ||
| struct Recipient { | ||
| // If false, the recipientAddress is the anchor of the profile | ||
| bool useRegistryAnchor; |
Member
There was a problem hiding this comment.
do we want to retain this? or are we doing it cause we already have this in DirectGrantsLite ?
Collaborator
Author
There was a problem hiding this comment.
i would suggest to keep it, to have it consistent between the strategies and other implementations
|
|
||
| /// @notice Stores the initialize data for the strategy | ||
| struct InitializeData { | ||
| bool useRegistryAnchor; |
| Metadata public distributionMetadata; | ||
|
|
||
| /// @notice Flag to indicate whether to use the registry anchor or not. | ||
| bool public useRegistryAnchor; |
| uint64 public poolEndTime; | ||
|
|
||
| /// @notice The total amount of tokens allocated to the payout. | ||
| uint256 public totalPayoutAmount; |
Member
There was a problem hiding this comment.
this is being used instead of fundPool right ?
Collaborator
Author
There was a problem hiding this comment.
not used anywhere, got removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes PAR-716