Added DSL, simplified polling logic, code cleanup#1
Open
lamba92 wants to merge 2 commits intoalllex:mainfrom
Open
Added DSL, simplified polling logic, code cleanup#1lamba92 wants to merge 2 commits intoalllex:mainfrom
lamba92 wants to merge 2 commits intoalllex:mainfrom
Conversation
alllex
reviewed
Dec 30, 2023
| kotlinx-serialization = "1.5.1" | ||
| ktor = "2.3.2" | ||
| log4j = "2.20.0" | ||
| kotlinTarget = "1.9.20" |
Owner
There was a problem hiding this comment.
❌ Let's not bump the target version of Kotlin without an explicit reason.
I also updated the dependency versions in a separate PR (#2), so let's remove the version updates from this one
Changes: - Most of the polling logic has been replaced with coroutine code. - Added TelegramBotUpdateBuilder DSL to build the bot - Exposed TelegramBotApiClient's properties to allows custom extension - Simplified TelegramBotApiClient's HttpClient defaults - Replaced sealed classes with sealed interfaces - Added logger and json to TelegramBotApiContext - Removed @OptIn annotations - Expanded star imports for code readability outside IDE - bump library versions - bump gradle wrapper version
- `startPolling` now uses `supervisorScope` to allow parallel execution of updates - better error logging when handling updates - TelegramBotApiContext is now a class, no need to have an interface for 3 parameters - dump new Kotlin APIs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: