Open
Conversation
Effectively, the way coroutines are used here is to mimic checked exceptions. This patch makes it more obvious and simplifies the implementation `debugMode` is aparently no longer needed since we don't juggle Continuations as actively as before
Author
|
I verified the validity of my patch by running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effectively, the way coroutines are used here is to mimic checked exceptions.
This patch makes it more obvious and simplifies the implementation
debugModeis aparently no longer needed since we don't juggle Continuations as actively as beforeFeel free to reject the PR for whatever reasons, I might be not following some of the steps to make the PR practical (for example, if you care about binary compatibility, I change some public APIs), my interest is purely theoretical.
I primarily submit the PR to let you know that the implementation can be simplified as I was reading trying to understand what the
suspendmachinery is for until I realized that it's just actually to mimic checked exceptions.