Open
Conversation
Conflicts: pennyblack/__init__.py
Conflicts: pennyblack/__init__.py
Conflicts: pennyblack/models/mail.py
this feature worked for me in a local development setup but isn't field testet yet closes allink#9
…hich aren't http or https this also inserts analytics data in the right place when a url has fragments
this closes allink#3
…in a content type
this feature is hidden by default because you should not send large emails to a bit mailing list
jobunit/change_form.html has {% trans "Newsletter Erstellen" %}, but it
should read {% trans "Send Newsletter" %} and allow the translations to
convert it appropriately.
Fix jobunit/change_form translations
Adding the request context to the unsubscribe view allows for a more versatile unsubscribe template
Some newsletters should be viewable by the public. A new `public_slug` field on the Job model describes which jobs should be viewable, and by what URL. Additionally, new public_url newsletter template parameter allows sharing links in the newsletter to point to the public location instead of the mail-specific url.
compatible to django 1.5
from PIL import Image works on both PIL and Pillow
jobunit/change_form.html has {% trans "Newsletter Erstellen" %}, but it
should read {% trans "Send Newsletter" %} and allow the translations to
convert it appropriately.
Adding the request context to the unsubscribe view allows for a more versatile unsubscribe template
from PIL import Image works on both PIL and Pillow
This fixes issue allink#43: The `NewsletterSubscriber.date_subscribed` default is `datetime.datetime.now()`, which has two problems: 1. The time is fixed when the module is loaded (it's the same for every added subscriber during one run of a script, or until the webserver is reloaded) 2. The date/time is not timezone-aware, causing warnings when timezones are enabled in Django 1.4 and newer
This fixes issue allink#43: The `NewsletterSubscriber.date_subscribed` default is `datetime.datetime.now()`, which has two problems: 1. The time is fixed when the module is loaded (it's the same for every added subscriber during one run of a script, or until the webserver is reloaded) 2. The date/time is not timezone-aware, causing warnings when timezones are enabled in Django 1.4 and newer Conflicts: pennyblack/module/subscriber/models.py
`Job.public_slug` is supposed to be able to be blank, but the uniqueness
constraint means that there can be only one blank ('') slug.
Fix this by changing "" -> None in `clean()`, and return None
for the `public_url` if there is no slug or if there is no valid reverse
url mapping.
Fix `Job.send`: 1. if `connection.send_messages raises` an exception, the `Job` status is set to 41 (error) but was not saved, so the `Job` status stays pending. Now it's saved on exception 2. Additionally, the `smtplib.SMTPRecipientsRefused` exception can be raised from `send_messages`, indicating that one of the messages could not be sent. This doesn't mean that the entire job is in error, just one of the recipients, but Job.send would abort the remainder of the sending anyway. Fix this by calling `newsletter_mail.bounce()` when this is encountered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jobunit/change_form.html has {% trans "Newsletter Erstellen" %}, but it
should read {% trans "Send Newsletter" %} and allow the translations to
convert it appropriately.
Fixes #37