deleted field softpage_enabled and added field link target which has a#73
Open
Cut3cumber wants to merge 1 commit intov2.8.0from
Open
deleted field softpage_enabled and added field link target which has a#73Cut3cumber wants to merge 1 commit intov2.8.0from
Cut3cumber wants to merge 1 commit intov2.8.0from
Conversation
property softpage_enabled so usage stays the same added posibility to choose between softpage and new window migrated field softpage ebabled so if it was set to true this would be represented in the new link_target field fix typo in readme
tuerlefl
reviewed
Apr 20, 2020
| NEW_WINDOW = 1 | ||
| SOFTPAGE = 2 | ||
|
|
||
| TARGET_CHOICES = ( |
Member
There was a problem hiding this comment.
please move "TARGET_CHOICES" to AllinkTeaserPlugin as a class attribute.
tuerlefl
reviewed
Apr 20, 2020
| return True if self.link_target == SOFTPAGE else False | ||
|
|
||
| @property | ||
| def new_window(self): |
tuerlefl
reviewed
Apr 20, 2020
| elif self.link_target == SOFTPAGE: | ||
| return 'data-icon-softpage' | ||
| else: | ||
| return None |
Member
There was a problem hiding this comment.
is "None" the correct default value to return here, when we want to open in the same window?
tuerlefl
reviewed
Apr 20, 2020
| @@ -4,6 +4,8 @@ | |||
| <div class="teaser__link"> | |||
| {% if instance.softpage_enabled %} | |||
Member
There was a problem hiding this comment.
this if/ else statement is probably obsolete, since you added the properties "link_icon" and "link_attributes" on the model, right?
tuerlefl
requested changes
Apr 20, 2020
Member
tuerlefl
left a comment
tuerlefl
left a comment
There was a problem hiding this comment.
let's discuss this tomorrow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
property softpage_enabled so usage stays the same
added posibility to choose between softpage and new window
migrated field softpage ebabled so if it was set to true this would be represented in the new link_target field
fix typo in readme