Skip to content

KANBAN-1163 fix production gene viewer regressions#1754

Merged
christabone merged 2 commits intostagefrom
KANBAN-1163_viewer-production-fixes
Apr 15, 2026
Merged

KANBAN-1163 fix production gene viewer regressions#1754
christabone merged 2 commits intostagefrom
KANBAN-1163_viewer-production-fixes

Conversation

@christabone
Copy link
Copy Markdown
Contributor

Summary

  • load the GO-CAM production bundle as an ES module
  • bump genomefeatures to the alias-normalization fix commit
  • add a regression test for the production web component initialization path

Testing

  • npm test -- --watchAll=false src/tests/initializeGOLibraryWebComponents.test.js
  • npm run build
  • local production preview checks for yeast, frog, and variant pages

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 15, 2026

Review

Changes look correct. Three things in this PR:

  1. type = 'module' on GO-CAM viz script — The production bundle is an .esm.js file, so it must be loaded with type = 'module'. Without this, browsers would reject the ESM import/export syntax in the bundle. Clear bug fix.

  2. genomefeatures bump — Pin moves to a new commit (alias-normalization fix). Lock file is consistent with package.json.

  3. New test — Verifies the production path sets type = 'module' on the correct script element. Test properly saves/restores NODE_ENV and cleans up document.head between runs.

No issues found. The ribbon-strips and ribbon-table scripts intentionally remain classic scripts (their bundles are non-ESM .js files), so the asymmetry is correct.

LGTM.

@christabone christabone merged commit 07d55b3 into stage Apr 15, 2026
5 checks passed
@christabone christabone deleted the KANBAN-1163_viewer-production-fixes branch April 15, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant